[FIX] hr_holidays_public: wrong computation in case resources in different countries #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent countries Fix an issue in hr_holidays_public where resource.calendar::_attendance_intervals_batch_exclude_public_holidays would return a wrong result when called with multiple resources working in different countries. The original implementation uses a context key employee_id to find the employee, which only allows this method to be called with a single employee. The fix searches for the employees related to the resources passed in arguments, and default to the context key if there are no provided resources. Also rework the implementation to use a python set rather than a list for faster in test.
|
Supersedes #47 |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at bd895cc. Thanks a lot for contributing to OCA. ❤️ |
|
Is this happening in 16? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in hr_holidays_public where
resource.calendar::_attendance_intervals_batch_exclude_public_holidays
would return a wrong result when called with multiple resources working
in different countries.
The original implementation uses a context key employee_id to find the
employee, which only allows this method to be called with a single
employee. The fix searches for the employees related to the resources
passed in arguments, and default to the context key if there are no
provided resources.
Also rework the implementation to use a python set rather than a list
for faster in test.