Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_holidays_public: wrong computation in case resources in different countries #98

Merged

Commits on Nov 18, 2023

  1. [FIX] hr_holidays_public: wrong computation in case resources in diff…

    …erent countries
    
    Fix an issue in hr_holidays_public where
    resource.calendar::_attendance_intervals_batch_exclude_public_holidays
    would return a wrong result when called with multiple resources working
    in different countries.
    
    The original implementation uses a context key employee_id to find the
    employee, which only allows this method to be called with a single
    employee. The fix searches for the employees related to the resources
    passed in arguments, and default to the context key if there are no
    provided resources.
    
    Also rework the implementation to use a python set rather than a list
    for faster in test.
    gurneyalex authored and dreispt committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    4ca7d56 View commit details
    Browse the repository at this point in the history