[16.0][FIX] base_multi_company: support in False search operators
#760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pedrobaeza, |
yajo
added a commit
to moduon/multi-company
that referenced
this pull request
Jan 29, 2025
Now that `base_multi_company` supports `('company_id', 'in', some_ids + [False])` domains since OCA#760, it's time to remove the (un)install hooks that changed those rules.
The fix is important when migrating a database from previous versions where these hooks didn't exist. In those cases, users wouldn't be able to browse some partners, getting a weird `AccessError`.
FWIW, [upstream rules changed for performance][2], so the uninstall hook had to be changed nevertheless.
[2]: odoo/odoo@a04df5c#diff-1f2cafa0e26df218210181c72e599c279fd093c4215d1dc1da5ef8875195e6c2L23-R23
@moduon MT-8863
1 task
yajo
force-pushed
the
16.0-base_multi_company-fix_in_false
branch
3 times, most recently
from
2805d27 to
d34f488
Compare
yajo
force-pushed
the
16.0-base_multi_company-fix_in_false
branch
from
d34f488 to
6875f5a
Compare
EmilioPascual
approved these changes
Jan 29, 2025
Before this commit, when doing a read with a domain such as [the one used by upstream `base.res_partner_rule`][1], the read failed to find records without company. This is now fixed in the base module, adding tested support for such operators. The only relevant part of the hooks that were provided to workaround the issue is extracted to a new `post_init_hook`. All other hooks are marked as deprecated. [1]: https://github.com/odoo/odoo/blob/db072461cddced2a8f65a64fb6d2ddf0dd79b38e/odoo/addons/base/security/base_security.xml#L23 @moduon MT-8863 MT-8873
yajo
force-pushed
the
16.0-base_multi_company-fix_in_false
branch
from
6875f5a to
aee7d28
Compare
Shide
approved these changes
Jan 29, 2025
|
This module is already migrated to 17 and the is a PR for 18. @victoralmau @pedrobaeza @chienandalu could you review please? We can fordward port to all versions. Thank you! 😄 Note Odoo 18 migration #708 |
victoralmau
approved these changes
Feb 10, 2025
pedrobaeza
changed the title
in False search operatorsin False search operators
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 93c447e. Thanks a lot for contributing to OCA. ❤️ |
yajo
added a commit
to moduon/multi-company
that referenced
this pull request
Feb 12, 2025
Now that `base_multi_company` supports `('company_id', 'in', some_ids + [False])` domains since OCA#760, it's time to remove the (un)install hooks that changed those rules.
The fix is important when migrating a database from previous versions where these hooks didn't exist. In those cases, users wouldn't be able to browse some partners, getting a weird `AccessError`.
FWIW, [upstream rules changed for performance][2], so the uninstall hook had to be changed nevertheless.
[2]: odoo/odoo@a04df5c#diff-1f2cafa0e26df218210181c72e599c279fd093c4215d1dc1da5ef8875195e6c2L23-R23
@moduon MT-8863
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when doing a read with a domain such as the one used by upstream
base.res_partner_rule, the read failed to find records without company.This is now fixed in the base module, adding tested support for such operators. The only relevant part of the hooks that were provided to workaround the issue is extracted to a new
post_init_hook. All other hooks are marked as deprecated.Instructions for functional tests: This refactor is internal and should not be noticed functionally. The modules
product_multi_companyandpartner_multi_companyshould work just as always. If so, then this is good.@moduon MT-8863 MT-8873