Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] product_multi_company: don't change rules, but respect previous company assignments #762

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FIX] product_multi_company: don't change rules, but respect previous company assignments #762

wants to merge 1 commit into from

Conversation

yajo
Copy link
Member

@yajo yajo commented Jan 29, 2025 •
edited
Loading

Remove lots of code thanks to #760.

Also, call the new fill_company_ids hook, to respect company assignments done before the module installation.

Draft until:

Instructions for functional tests: This refactor is internal and should not be noticed functionally. The module product_multi_company should work just as always. If so, then this is good.

@moduon MT-8873

@yajo yajo force-pushed the 16.0-product_multi_company-fix_hooks branch from dbf4b41 to 02edfb3 Compare January 29, 2025 12:48
@yajo yajo force-pushed the 16.0-product_multi_company-fix_hooks branch from 02edfb3 to ad2634d Compare February 12, 2025 09:23
@yajo yajo marked this pull request as ready for review February 12, 2025 09:23
@yajo yajo mentioned this pull request Feb 12, 2025
Merged
@pedrobaeza pedrobaeza changed the title [FIX] product_multi_company: don't change rules, but respect previous company assignments [16.0][FIX] product_multi_company: don't change rules, but respect previous company assignments Feb 12, 2025
@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 12, 2025
pedrobaeza
pedrobaeza reviewed Feb 12, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you include here migration scripts the same as in partner_multi_company?

@yajo
[FIX] product_multi_company: don't change rules, but respect previous…
39e389f 
… company assignments

Remove lots of code thanks to OCA#760.

Also, call the new `fill_company_ids` hook, to respect company assignments done before the module installation.

@moduon MT-8873
@yajo yajo force-pushed the 16.0-product_multi_company-fix_hooks branch from ad2634d to 39e389f Compare February 14, 2025 10:00
@yajo
Copy link
Member Author

yajo commented Feb 14, 2025

You're right, thanks for the review. Script added.

pedrobaeza
pedrobaeza approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge major

Please fw-port it.

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-762-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 3, 2025
@OCA-git-bot
Merge PR #762 into 16.0
57dc899 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-762-by-pedrobaeza-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

@yajo please check the CI

@PieterPaulussen
Copy link

@yajo The tests for this module are broken. Please check https://github.com/OCA/multi-company/actions/runs/13632724910/job/38103974812#step:8:847. Are you available to fix this?
Additionally, Pedro asks to forward port these fixes to v17.0 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@PieterPaulussen PieterPaulussen PieterPaulussen approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yajo @OCA-git-bot @pedrobaeza @PieterPaulussen