[17.0][MIG] pos_order_to_sale_order #1234

chaule97 · 2024-08-29T07:25:45Z

No description provided.

victorvermot · 2024-09-02T10:02:26Z

Tests are fixed in this pr #1232

cyrilmanuel

LGTM but shall add the other pr to fix the test or add a kink here to specifiy that it's required for merge this one

Ricardoalso

Depends on #1232 but otherwise LGTM

ivantodorovich · 2024-09-18T11:34:15Z

/ocabot merge nobump

OCA-git-bot · 2024-09-18T11:34:22Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1234-by-ivantodorovich-bump-nobump, awaiting test results.

Signed-off-by ivantodorovich

* [ADD] new module pos_order_to_sale_order

…ion of this module (price unit loss, and pricelist) if pos_pricelist is installed

[FIX] Remove console.log ; [IMP] Do not import js files in backend [IMP] apply new readme structure [FIX] remove useless demo file [FIX] some pylint issues [REF] add maintainers and developpment status

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-8.0/pos-8.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-8-0/pos-8-0-pos_order_to_sale_order/

Co-authored-by: Iván Todorovich <[email protected]>

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_to_sale_order/

Currently translated at 100.0% (23 of 23 strings) Translation: pos-12.0/pos-12.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_to_sale_order/es/

…e_menu

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_order_to_sale_order/

Currently translated at 100.0% (21 of 21 strings) Translation: pos-16.0/pos-16.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_order_to_sale_order/it/

…repare function

…er line name fields

…sale_order_line_multiline_description_sale to avoid to write on sale.order.line after having creating the sale.order.line

Currently translated at 100.0% (21 of 21 strings) Translation: pos-16.0/pos-16.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_order_to_sale_order/pt_BR/

OCA-git-bot · 2024-09-18T11:42:22Z

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-1234-by-ivantodorovich-bump-nobump, awaiting test results.

Signed-off-by ivantodorovich

OCA-git-bot · 2024-09-18T11:49:23Z

@ivantodorovich The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name pos --branch 17.0 --addons-dir /tmp/tmpkupbgngq --commit failed with output:

/tmp/tmpkupbgngq/pos_order_to_sale_order/README.rst:86: (ERROR/3) Duplicate substitution definition name: "image1".
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 8, in <module>
    sys.exit(gen_addon_readme())
             ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 422, in publish_file
    output, publisher = publish_programmatically(
                        ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 722, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 234, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 70, in read
    self.parse()
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 76, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/__init__.py", line 184, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 169, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 3034, in text
    self.section(title.lstrip(), source, style, lineno + 1, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
                   ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2790, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
                   ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2357, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2369, in explicit_construct
    return method(self, expmatch)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2087, in substitution_def
    self.document.note_substitution_def(
  File "/ocamt/lib/python3.12/site-packages/docutils/nodes.py", line 1536, in note_substitution_def
    msg = self.reporter.error(
          ^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 231, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 197, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmpkupbgngq/pos_order_to_sale_order/README.rst:86: (ERROR/3) Duplicate substitution definition name: "image1".

OCA-git-bot · 2024-09-18T11:52:43Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

chaule97 · 2024-09-24T04:27:51Z

Hi @ivantodorovich, I fixed the issue, would you mind calling the merge bot again?

ivantodorovich · 2024-09-24T11:18:52Z

Thanks :)

/ocabot merge nobump

OCA-git-bot · 2024-09-24T11:19:01Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1234-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot · 2024-09-24T11:25:56Z

Congratulations, your PR was merged at c3a80ba. Thanks a lot for contributing to OCA. ❤️

chaule97 force-pushed the 17.0-mig-pos_order_to_sale_order branch from c924981 to 6c91e33 Compare August 29, 2024 11:14

chaule97 mentioned this pull request Aug 30, 2024

[17.0][FIX] pos_lot_barcode: fix testcase #1232

Merged

cyrilmanuel approved these changes Sep 2, 2024

View reviewed changes

Ricardoalso approved these changes Sep 2, 2024

View reviewed changes

OCA-git-bot added the approved label Sep 2, 2024

manuelcalerosolis approved these changes Sep 16, 2024

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Sep 18, 2024

Merge PR #1234 into 17.0

5671edd

Signed-off-by ivantodorovich

OCA-git-bot added the bot is merging ⏳ label Sep 18, 2024

legalsylvain and others added 19 commits September 18, 2024 18:34

[8.0] [ADD] pos order to sale order (w/o picking) (OCA#188)

018fdcb

* [ADD] new module pos_order_to_sale_order

[FIX] taxes was dropped in the sale order lines. [IMP] Remove limitat…

502aa88

…ion of this module (price unit loss, and pricelist) if pos_pricelist is installed

[BUMP] version

b050974

Coquille + ajout (BL) pour boutons "vente livrée"

90f611b

[FIX] por_order_to_sale_order: PEP8

86997d7

[UPD] Update pos_order_to_sale_order.pot

ae3c9c9

[FIX] do not allow to create sale order several times;

9c824c4

[FIX] Remove console.log ; [IMP] Do not import js files in backend [IMP] apply new readme structure [FIX] remove useless demo file [FIX] some pylint issues [REF] add maintainers and developpment status

[UPD] README.rst

c405523

[UPD] Update pos_order_to_sale_order.pot

8b1f905

Update translation files

6755ff3

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-8.0/pos-8.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-8-0/pos-8-0-pos_order_to_sale_order/

[REF] pos_order_to_sale_order: Black python code

e82dcd8

[MIG] pos_order_to_sale_order: Migration to 12.0

d014a32

[FIX] remove commented code

32ffd6c

Co-authored-by: Iván Todorovich <[email protected]>

[UPD] Update pos_order_to_sale_order.pot

dc7f8a2

[UPD] README.rst

6c55f5a

pos_order_to_sale_order 12.0.1.0.1

5ab6334

Update translation files

c2a34cb

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_to_sale_order/

Added translation using Weblate (Spanish)

a9d4e9f

Translated using Weblate (Spanish)

9093314

Currently translated at 100.0% (23 of 23 strings) Translation: pos-12.0/pos-12.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_order_to_sale_order/es/

legalsylvain and others added 13 commits September 18, 2024 18:34

[FIX] pos_order_to_sale_order : make test compatible with pos_minimiz…

0114bdd

…e_menu

Update translation files

3f6622e

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_order_to_sale_order/

Translated using Weblate (Italian)

8edaf2e

Currently translated at 100.0% (21 of 21 strings) Translation: pos-16.0/pos-16.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_order_to_sale_order/it/

[REF] pos_order_to_sale_order : add sale order line sequence in the p…

4d05d51

…repare function

[IMP] pos_order_to_sale_order : use customer_note to prepare sale ord…

e399a86

…er line name fields

[IMP] pos_order_to_sale_order : performance : directly overload _get_…

875ace4

…sale_order_line_multiline_description_sale to avoid to write on sale.order.line after having creating the sale.order.line

[BOT] post-merge updates

1f9aedc

[IMP] pos_order_to_sale_order: Code is refactored and tests are updated.

1beed92

[BOT] post-merge updates

5645004

Translated using Weblate (Portuguese (Brazil))

f31545a

Currently translated at 100.0% (21 of 21 strings) Translation: pos-16.0/pos-16.0-pos_order_to_sale_order Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_order_to_sale_order/pt_BR/

[IMP] pos_order_to_sale_order: use test helpers

dd96861

[BOT] post-merge updates

0338169

[IMP] pos_order_to_sale_order: pre-commit auto fixes

77b228a

chaule97 force-pushed the 17.0-mig-pos_order_to_sale_order branch from 6c91e33 to e341017 Compare September 18, 2024 11:35

OCA-git-bot added a commit that referenced this pull request Sep 18, 2024

Merge PR #1234 into 17.0

b86c0a2

Signed-off-by ivantodorovich

OCA-git-bot added ready to merge and removed bot is merging ⏳ labels Sep 18, 2024

[MIG] pos_order_to_sale_order: Migration to 17.0

8d6e460

chaule97 force-pushed the 17.0-mig-pos_order_to_sale_order branch from e341017 to 8d6e460 Compare September 24, 2024 04:15

OCA-git-bot added the bot is merging ⏳ label Sep 24, 2024

OCA-git-bot merged commit 8cdd1a2 into OCA:17.0 Sep 24, 2024
9 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] pos_order_to_sale_order #1234

[17.0][MIG] pos_order_to_sale_order #1234

chaule97 commented Aug 29, 2024

victorvermot commented Sep 2, 2024

cyrilmanuel left a comment

Ricardoalso left a comment

ivantodorovich commented Sep 18, 2024

OCA-git-bot commented Sep 18, 2024

OCA-git-bot commented Sep 18, 2024

OCA-git-bot commented Sep 18, 2024

OCA-git-bot commented Sep 18, 2024

chaule97 commented Sep 24, 2024

ivantodorovich commented Sep 24, 2024

OCA-git-bot commented Sep 24, 2024

OCA-git-bot commented Sep 24, 2024

[17.0][MIG] pos_order_to_sale_order #1234

[17.0][MIG] pos_order_to_sale_order #1234

Conversation

chaule97 commented Aug 29, 2024

victorvermot commented Sep 2, 2024

cyrilmanuel left a comment

Choose a reason for hiding this comment

Ricardoalso left a comment

Choose a reason for hiding this comment

ivantodorovich commented Sep 18, 2024

OCA-git-bot commented Sep 18, 2024

OCA-git-bot commented Sep 18, 2024

OCA-git-bot commented Sep 18, 2024

OCA-git-bot commented Sep 18, 2024

chaule97 commented Sep 24, 2024

ivantodorovich commented Sep 24, 2024

OCA-git-bot commented Sep 24, 2024

OCA-git-bot commented Sep 24, 2024