[17.0][MIG] product_main_supplierinfo #1660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no specific record are found by the first filter. The Odoo default method will return all active supplier info. Which will include also supplier info record related to other specific variant. With this change if some supplier info related to the product variant exist, they will be returned instead. Also add a sort on the price to have the same behaviour than on a purchase order line for the price selected.
adriresu
force-pushed
the
17.0-mig-product_main_supplierinfo
branch
from
962ec11
to
7c662c7
Compare
|
Can you review, please? |
|
Tested on runboat 👍 |
|
Can you review please? |
flotho
suggested changes
Jun 26, 2024
| if not sellers: | ||
| sellers = all_sellers.filtered(lambda s: (s.product_id == self)) | ||
| if not sellers: | ||
| sellers = sellers = all_sellers.filtered(lambda s: not s.product_id) |
There was a problem hiding this comment.
this line is weird, could you explain the use of the duplicate assignation on the same variable?
There was a problem hiding this comment.
This looks like a typo, should be IMO
Suggested change
| sellers = sellers = all_sellers.filtered(lambda s: not s.product_id) | |
| sellers = all_sellers.filtered(lambda s: not s.product_id) |
|
Also the directory |
Anxo82
force-pushed
the
17.0-mig-product_main_supplierinfo
branch
from
7c662c7
to
08a9af4
Compare
|
Done! Review please @TDu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration, reused #1353 (Unfinished migration to v16.0)