[18.0][MIG] product_state: Migration to 18.0 #1795

natuan9 · 2024-12-03T03:15:04Z

No description provided.

* [10.0] re-introduce state field on product * [ADD] add setup for product state

I've added both field content and help to ease understand the possibilities (draft and sellable have different meaning than In Development and Normal

Currently translated at 100.0% (6 of 6 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_state/pt/

Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_state/de/

Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_state/fr/ Translated using Weblate (French) Currently translated at 55.2% (16 of 29 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_state/fr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-13.0/product-attribute-13.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_state/ [MIG] product_state: Migration to 14.0

Application: False

Currently translated at 93.1% (27 of 29 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_state/nl/

As fields are on the form view, a write is called with them. This is an unwanted behaviour.

…emo data

* Fix bug when inverting non-exist new state * Show default and active fields in product state form * Refactor inverse state to use with variant state

Co-authored-by: Iryna Vyshnevska <[email protected]>

Translated using Weblate (Catalan) Currently translated at 93.7% (30 of 32 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_state/ca/

[UPD] Update product_state.pot [UPD] README.rst

Translated using Weblate (Italian) Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_state/it/

Translated using Weblate (Italian) Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_state/it/ Translated using Weblate (Italian) Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_state/it/ Translated using Weblate (Spanish) Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_state/es/ [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_state/ Translated using Weblate (Spanish) Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_state/es/ Translated using Weblate (Italian) Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_state/it/ Translated using Weblate (Italian) Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_state/it/

The product state shouldn't be copied when copying the product so this adds copy=False to the state field. [IMP] product_state: Add test for copy [FIX] Test

ajaniszewska-dev

LG

rousseldenis · 2024-12-10T15:45:18Z

/ocabot migration product_state

rousseldenis · 2024-12-10T15:46:26Z

product_state/models/product_template.py

@@ -55,10 +55,10 @@ def _set_product_state_id(self, record):
        ProductState = record.env["product.state"]
        product_state = ProductState.search([("code", "=", record.state)], limit=1)
        if record.state and not product_state:
-            msg = _("The product state code %s could not be found.")
+            msg = self.env._("The product state code %s could not be found.")


Use the translation function arguments instead.

this is the new way to translate 😉
https://www.odoo.com/documentation/18.0/developer/howtos/translations.html#explicit-exports

rousseldenis · 2024-12-10T15:46:43Z

product_state/__manifest__.py

    "license": "AGPL-3",
-    "depends": ["product", "sale"],
+    "depends": ["product", "sale", "stock"],


Why adding this new dependency ?

this sounds wrong

Thanks for review, adding this new dependency because the ir.model.access.csv file references the stock.group_stock_manager group.
This access was added in 14.0 by aleuffre (#1124)
I have also asked him why the dependency on the stock module was not added (#1124 (comment))

Thanks for the reference. Although that sounds wrong :/

@natuan9 I'd remove it and fix it w/ a glue module. Then they'll have to fix the module on v14 by backporting the work from v18. See my proposal on the PR on v14.

@rousseldenis WDYT?

thanks for your proposal, and I will implement it in a fix commit

Should I create a new PR for adding a glue module?

Yes, add a separate commit here to remove dependency (to be backported) and entry in security.

Then, add a new PR to add product_state_stock

hmm not sure if that's a good name... we already have https://github.com/OCA/product-attribute/tree/14.0/product_stock_state 😵

What about product_state_stock_security or product_state_stock_base?

a seperate commit

[18.0][ADD] product_state_stock_base #1819

[18.0][ADD] product_state_sale #1818
They're ready for review

simahawk

dependency to fix

Cédric Pigeon (ACSONE) and others added 30 commits November 27, 2024 18:50

re-introduce state field on product (OCA#261)

37db887

* [10.0] re-introduce state field on product * [ADD] add setup for product state

add product state on tree view

b0c3222

product_state: Migration to 11.0

60f424b

[MIG] product_state v11 to v12

d1e282c

describe the state field

5f5ed1d

I've added both field content and help to ease understand the possibilities (draft and sellable have different meaning than In Development and Normal

remove space before ":"

54e44e4

[MIG] product_state to v13

f8744be

[IMP] product_state

c23f86b

[CHG] some code cleaning to make it v13 compliant

c0f52a7

Translated using Weblate (German)

26eca63

Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_state Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_state/de/

[MIG] product_state: Migration to 14.0

870b413

[14.0][IMP] product_state: Add default value, tests

5790612

[14.0][IMP] product_state: Add tracking, index and fix default value

9558119

[14.0][FIX] product_state: Good xml id

75ff100

update manifest

e4f23a5

Application: False

[14.0][IMP] product_state: Prevent a write with both values

67547f0

As fields are on the form view, a write is called with them. This is an unwanted behaviour.

Move default states on product_state and product_tier_validation to d…

77d318e

…emo data

[14.0][IMP] product_state: Add an inverse method on product_state_id

710439d

[IMP] product_state: fix issue, refactor inverse state

773ef2c

* Fix bug when inverting non-exist new state * Show default and active fields in product state form * Refactor inverse state to use with variant state

[IMP] product_state: use id in default of field

80ef575

Co-authored-by: Iryna Vyshnevska <[email protected]>

[MIG] product_state: Migration to 15.0

424c35e

[15.0][FIX] product_state: solving problem from migration

4f70668

[MIG] product_state: Migration to 16.0

e3c0b28

[UPD] Update product_state.pot [UPD] README.rst

NICO-SOLUTIONS and others added 5 commits November 28, 2024 21:04

[IMP] product_state: pre-commit auto fixes

d8b1eb2

[MIG] product_state: Migration to 17.0

89a69cf

[IMP] product_state (copy=False)

b9a4d83

The product state shouldn't be copied when copying the product so this adds copy=False to the state field. [IMP] product_state: Add test for copy [FIX] Test

product_state: move access to Sales + Inventory Manager

7af51a1

[IMP] product_state: pre-commit auto fixes

69e0390

natuan9 mentioned this pull request Dec 3, 2024

[18.0][MIG] product_status: Migration to 18.0 #1796

Open

ajaniszewska-dev approved these changes Dec 9, 2024

View reviewed changes

sebalix approved these changes Dec 10, 2024

View reviewed changes

OCA-git-bot added the approved label Dec 10, 2024

rousseldenis added the migration label Dec 10, 2024

OCA-git-bot added this to the 18.0 milestone Dec 10, 2024

OCA-git-bot mentioned this pull request Dec 10, 2024

Migration to version 18.0 #1741

Open

25 tasks

rousseldenis requested changes Dec 10, 2024

View reviewed changes

OCA-git-bot removed the approved label Dec 10, 2024

simahawk requested changes Dec 10, 2024

View reviewed changes

natuan9 added 2 commits December 12, 2024 12:26

[MIG] product_state: Migration to 18.0

a38eb37

[IMP] product_state: Remove dependencies on stock and sale modules

3ae6a13

natuan9 force-pushed the 18.0-mig-product_state branch from f813f33 to 3ae6a13 Compare December 12, 2024 11:22

This was referenced Dec 13, 2024

[18.0][ADD] product_state_sale #1818

Open

[18.0][ADD] product_state_stock_base #1819

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] product_state: Migration to 18.0 #1795

[18.0][MIG] product_state: Migration to 18.0 #1795

natuan9 commented Dec 3, 2024

ajaniszewska-dev left a comment

rousseldenis commented Dec 10, 2024

rousseldenis Dec 10, 2024

simahawk Dec 10, 2024

rousseldenis Dec 10, 2024

simahawk Dec 10, 2024

natuan9 Dec 11, 2024

simahawk Dec 11, 2024

simahawk Dec 11, 2024

natuan9 Dec 12, 2024 •

edited

Loading

natuan9 Dec 12, 2024

rousseldenis Dec 12, 2024 •

edited

Loading

simahawk Dec 12, 2024

natuan9 Dec 13, 2024

simahawk left a comment

[18.0][MIG] product_state: Migration to 18.0 #1795

Are you sure you want to change the base?

[18.0][MIG] product_state: Migration to 18.0 #1795

Conversation

natuan9 commented Dec 3, 2024

ajaniszewska-dev left a comment

Choose a reason for hiding this comment

rousseldenis commented Dec 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

natuan9 Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk left a comment

Choose a reason for hiding this comment

natuan9 Dec 12, 2024 •

edited

Loading

rousseldenis Dec 12, 2024 •

edited

Loading