Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] product_packaging_level: Migration to 18.0 #1806

Open
wants to merge 34 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] product_packaging_level: Migration to 18.0 #1806

wants to merge 34 commits into from

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Dec 9, 2024 •
edited
Loading

Note

Changes in 18.0

  1. get became private since here
  2. _lang_get_xxx were merged into one api _get_data which is simpler and easy to extend since here

This changes

  1. Took this occasion to fix an issue
    [FIX] product_packaging_level: cannot input name with user_defined policy

This was referenced Dec 9, 2024
Open
Open
Open
Open
@rousseldenis
Copy link
Contributor

/ocabot migration product_packaging_level

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 10, 2024
sebalix
sebalix approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, I made a comment on the v17 migration PR about a change that should land there, and not in the v18 migration commit IMO: #1662

But not blocking.

@trisdoan trisdoan marked this pull request as draft December 13, 2024 10:06
@trisdoan
Copy link
Contributor Author

trisdoan commented Dec 13, 2024 •
edited
Loading

DRAFT: inspect weird bug: _active_languages does not exist

@trisdoan trisdoan force-pushed the 18.0-mig-product_packaging_level branch from 6ec3f39 to 547e2ac Compare December 13, 2024 10:15
@trisdoan trisdoan marked this pull request as ready for review December 13, 2024 10:16
@trisdoan trisdoan mentioned this pull request Dec 16, 2024
Open
@trisdoan trisdoan force-pushed the 18.0-mig-product_packaging_level branch from 547e2ac to 3970b1c Compare December 16, 2024 05:06
@trisdoan trisdoan mentioned this pull request Dec 16, 2024
Draft
jbaudoux
jbaudoux approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@thienvh332 thienvh332 mentioned this pull request Jan 6, 2025
Open
ivantodorovich
ivantodorovich reviewed Jan 6, 2025
View reviewed changes
product_packaging_level/models/product_packaging.py Outdated
Comment on lines 137 to 142
def _compute_display_name(self):
for record in self:
if record.product_id and record.packaging_level_id:
record.display_name = record._get_name_from_policy(lang=self.env.lang)
else:
return super()._compute_display_name()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct.

it's not properly handling the recordset. The return shouldn't be within the loop.

Copy link
Contributor Author

@trisdoan trisdoan Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ivantodorovich, indeed, I updated the code, will include it in the backport as well: #1809

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Ivorra78 and others added 25 commits January 8, 2025 15:07
@Ivorra78 @trisdoan
Translated using Weblate (Spanish)
386f7f5 
Currently translated at 100.0% (25 of 25 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/es/
@anothingguy @trisdoan
[IMP] product_packaging_level: configure product packaging name
81e0030
@trisdoan
[UPD] Update product_packaging_level.pot
d113d1a
@OCA-git-bot @trisdoan
[BOT] post-merge updates
330df57
@weblate @trisdoan
Update translation files
3adf3d6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/
@Ivorra78 @trisdoan
Translated using Weblate (Spanish)
a6c0269 
Currently translated at 100.0% (32 of 32 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/es/
@mymage @trisdoan
Added translation using Weblate (Italian)
4b91dbd
@mymage @trisdoan
Translated using Weblate (Italian)
a425a37 
Currently translated at 71.8% (23 of 32 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/it/
@mymage @trisdoan
Translated using Weblate (Italian)
2dfc698 
Currently translated at 100.0% (32 of 32 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/it/
@p-tombez @trisdoan
[16.0][FIX] product_packaging_level: Preserve sequence order
73f39ed
@trisdoan
[UPD] Update product_packaging_level.pot
c691c4e
@OCA-git-bot @trisdoan
[BOT] post-merge updates
c307ce6
@weblate @trisdoan
Update translation files
e91c5cb 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/
@Ivorra78 @trisdoan
Translated using Weblate (Spanish)
c6f0930 
Currently translated at 100.0% (32 of 32 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/es/
@trisdoan
[IMP]product_packaging_level: recover name_get policy flow
3b29c8c
@trisdoan
[UPD] Update product_packaging_level.pot
2d0c3bb
@OCA-git-bot @trisdoan
[BOT] post-merge updates
8b7d381
@weblate @trisdoan
Update translation files
5b552da 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/
@Ivorra78 @trisdoan
Translated using Weblate (Spanish)
6969fef 
Currently translated at 100.0% (34 of 34 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/es/
@mymage @trisdoan
Translated using Weblate (Italian)
2681635 
Currently translated at 100.0% (34 of 34 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/it/
@mymage @trisdoan
Translated using Weblate (Italian)
56d7f29 
Currently translated at 100.0% (34 of 34 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/it/
@bizzappdev @trisdoan
[IMP] product_packaging_level: pre-commit auto fixes
b0a59d7
@bizzappdev @trisdoan
[MIG] product_packaging_level: Migration to 17.0
760ce4a
@trisdoan
[IMP] product_packaging_level: pre-commit auto fixes
1151bef
@trisdoan
[MIG] product_packaging_level: Migration to 18.0
7e58978
@trisdoan trisdoan force-pushed the 18.0-mig-product_packaging_level branch from 3970b1c to 0239c61 Compare January 8, 2025 08:12
@trisdoan trisdoan force-pushed the 18.0-mig-product_packaging_level branch from 0239c61 to b16bbf3 Compare January 8, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

@sebalix sebalix sebalix approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees
No one assigned
Labels
approved migration needs review ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.