[16.0][IMP] web_notify:t3894 Allow notify with sound #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabbasovDinar
changed the title
GabbasovDinar
force-pushed
the
16.0-t3894-web_notify-sound-on-notification
branch
from
e1ca00d
to
d8630d6
Compare
chienandalu
reviewed
Oct 9, 2024
| * specified settings like volume and looping. It also provides the ability | ||
| * to trigger actions when the audio playback ends. | ||
| */ | ||
| export class AudioPlayer extends Component { |
There was a problem hiding this comment.
Why not using a service like SoundEffects
There was a problem hiding this comment.
this service is limited to predefined sound effect settings and does not allow you to specify a link to any sound. In my case, only the sound effect link is passed for playback, which allows any sound to be dynamically played back
There was a problem hiding this comment.
Yes, I mean, you can take inspiration in that code to implement your own sound service, resulting in a simpler impletation
There was a problem hiding this comment.
@chienandalu I was already inspired by this effect to write the current solution :-)
GabbasovDinar
force-pushed
the
16.0-t3894-web_notify-sound-on-notification
branch
from
d8630d6
to
77e3a53
Compare
GabbasovDinar
force-pushed
the
16.0-t3894-web_notify-sound-on-notification
branch
from
77e3a53
to
0a1ad0d
Compare
GabbasovDinar
force-pushed
the
16.0-t3894-web_notify-sound-on-notification
branch
from
0a1ad0d
to
50e7956
Compare
|
Hi @chienandalu could you please review the code again? Thank you in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow you to send notifications with an audible alarm.