Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure on missing server value in getTemporalData #760

Merged
merged 1 commit into from
May 14, 2024

Conversation

ganisimov
Copy link

When connection details is set up using Connection String, server value is NULL. It caused failure on attempt to extract dbName from server.
Now, dbName is set to NA if server is not provided (new behavior) as well as when it doesn't contain slash character ("/") (existent behavior)

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (5fdd05c) to head (c7cd126).

Files Patch % Lines
R/getTemporalData.r 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #760       +/-   ##
===========================================
- Coverage    12.74%   0.00%   -12.75%     
===========================================
  Files           14      14               
  Lines         3649    3651        +2     
===========================================
- Hits           465       0      -465     
- Misses        3184    3651      +467     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fdefalco fdefalco merged commit 9e5c4df into OHDSI:develop May 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants