Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependancies #518

Merged
merged 19 commits into from
Jan 10, 2025
Merged

Dependancies #518

merged 19 commits into from
Jan 10, 2025

Conversation

egillax
Copy link
Collaborator

@egillax egillax commented Jan 9, 2025

Add more dependencies to suggests and put behind ensure_installed commands.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 85.06589% with 204 lines in your changes missing coverage. Please review.

Project coverage is 87.72%. Comparing base (19d59ba) to head (50374a0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
R/HelperFunctions.R 58.49% 44 Missing ⚠️
R/Plotting.R 92.98% 39 Missing ⚠️
R/EvaluationSummary.R 82.53% 33 Missing ⚠️
R/CyclopsModels.R 78.40% 27 Missing ⚠️
R/LearningCurve.R 73.62% 24 Missing ⚠️
R/EvaluatePlp.R 75.00% 15 Missing ⚠️
R/CalibrationSummary.R 92.94% 6 Missing ⚠️
R/SklearnClassifierSettings.R 85.71% 6 Missing ⚠️
R/ViewShinyPlp.R 0.00% 5 Missing ⚠️
R/FeatureEngineering.R 86.66% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #518      +/-   ##
===========================================
+ Coverage    86.92%   87.72%   +0.79%     
===========================================
  Files           50       49       -1     
  Lines        10477    10564      +87     
===========================================
+ Hits          9107     9267     +160     
+ Misses        1370     1297      -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egillax
Copy link
Collaborator Author

egillax commented Jan 10, 2025

I ended up removing the following dependencies from suggests as well:

AUC: Doesn't seem to be used anymore
devtools: Only used in package maintenance to check spelling, removed that check. Can run it manually if required.
markdown: This is for markdown v1, which I believe rmarkdown has superseded.
plyr: Is not used directly, but is a dependency of pROC
pool: Not directly used but indirectly through DatabaseConnector

I did verify all tests passed with out these.

@egillax
Copy link
Collaborator Author

egillax commented Jan 10, 2025

These changes affect how many packages are installed (pkgndep::pkgndep):

develop:

- 93 packages are required for installing.
- 236 packages are required if installing packages listed in all fields in DESCRIPTION.

This PR:

- 72 packages are required for installing.
- 216 packages are required if installing packages listed in all fields in DESCRIPTION.

@egillax egillax merged commit baa52d0 into develop Jan 10, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant