Add Pylint command to jinja template #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After using the template on another repository, the ruff, pylint and mypy commands run but finish with an error that stops subsequent commands from running: make: *** [<command>] Error
Addition to PRAfter using the template on another repository, when using
Adding in |
Comment on lines
+26
to
+27
| {{ package_manager }} run ruff check . || true | ||
| {{ package_manager }} run pylint {{ module_name }} || true |
There was a problem hiding this comment.
The || true at the end of these commands means that the command will always exit with a status of 0 (success), regardless of whether the linter encounters any issues. Since these are used in CI this is not recommended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Pylint is mentioned in the README.md but not implemented in the MAKEFILE of the template and when the template is used, evident in the demo.
How to review
Pull changes, use template, run
make lintto run black, ruff, mypy and pylint.