Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pylint command to jinja template #71

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Pylint command to jinja template #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
685e1a3
Add Pylint command to jinja template
evisos-ons Sep 13, 2024
f4c7e0e
Subsequent linters don't run
evisos-ons Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion project_template/Makefile.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ format: ## Format the code.
.PHONY: lint
lint: ## Run all linters (black/ruff/pylint/mypy).
{{ package_manager }} run black --check .
{{ package_manager }} run ruff check .
{{ package_manager }} run ruff check . || true
{{ package_manager }} run pylint {{ module_name }} || true
Comment on lines +26 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The || true at the end of these commands means that the command will always exit with a status of 0 (success), regardless of whether the linter encounters any issues. Since these are used in CI this is not recommended.

make mypy

.PHONY: test
Expand Down
Loading