-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ping instead of checking pod readiness #1038
Draft
com6056
wants to merge
5
commits into
OT-CONTAINER-KIT:master
Choose a base branch
from
muxinc:jrodgers-ping-for-ready
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
com6056
changed the title
ping instead of checking pod readiness
fix: ping instead of checking pod readiness
Aug 2, 2024
com6056
force-pushed
the
jrodgers-ping-for-ready
branch
from
August 2, 2024 17:20
d1e81b1
to
d14a505
Compare
Signed-off-by: Jordan Rodgers <[email protected]>
com6056
force-pushed
the
jrodgers-ping-for-ready
branch
from
August 2, 2024 17:20
d14a505
to
6de507e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1038 +/- ##
===========================================
+ Coverage 35.20% 45.97% +10.76%
===========================================
Files 19 20 +1
Lines 3213 2730 -483
===========================================
+ Hits 1131 1255 +124
+ Misses 2015 1400 -615
- Partials 67 75 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jordan Rodgers <[email protected]>
com6056
force-pushed
the
jrodgers-ping-for-ready
branch
from
August 2, 2024 17:49
c2f6680
to
a9f97cb
Compare
Signed-off-by: Jordan Rodgers <[email protected]>
com6056
force-pushed
the
jrodgers-ping-for-ready
branch
from
August 2, 2024 18:06
f98328d
to
62b750c
Compare
Signed-off-by: Jordan Rodgers <[email protected]>
Signed-off-by: Jordan Rodgers <[email protected]>
com6056
force-pushed
the
jrodgers-ping-for-ready
branch
from
August 2, 2024 18:59
3f6cb3d
to
ae15bc7
Compare
@com6056 Could you please resolve the conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, since the operator relies on checking pod readiness, it makes using a more robust readiness probe not possible. This changes it so instead of checking the pod readiness, we just directly
PING
all of the redis nodes instead (which the default readiness probe does anyways).Also exposes
podManagementPolicy
to be configurable since you needParallel
if you are using readiness probes that check cluster health.Fixes #1016
Type of change
Checklist
Additional Context