Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent editing collection while all items aren't resolved #3061

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

keikari
Copy link
Contributor

@keikari keikari commented Feb 20, 2024

Fixes

Collection items randomly disappearing when editing public list.
Assuming it happens due to there being no check if collection items have resolved before doing the edit. And if there were items still resolving, those would get deleted. (I think)

Not sure how to repro the issue exactly, but comment in the code suggests this being the case // The resolve calls will NOT return items when they still are in a previous call's 'Processing' state.
So added a check for collection items being resolved, and updated the fetching to handle cases of deleted claims.

Note:
Missing still proper error messaging, currently just shows error pop-up asking to try again.

@tzarebczan tzarebczan merged commit 6c1b5e3 into OdyseeTeam:master Feb 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants