Prevent editing collection while all items aren't resolved #3061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Collection items randomly disappearing when editing public list.
Assuming it happens due to there being no check if collection items have resolved before doing the edit. And if there were items still resolving, those would get deleted. (I think)
Not sure how to repro the issue exactly, but comment in the code suggests this being the case
// The resolve calls will NOT return items when they still are in a previous call's 'Processing' state.
So added a check for collection items being resolved, and updated the fetching to handle cases of deleted claims.
Note:
Missing still proper error messaging, currently just shows error pop-up asking to try again.