Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Make the Python language verification suite pass against Python 3.12 #333

Merged
merged 9 commits into from
Jun 8, 2024
Merged

[python] Make the Python language verification suite pass against Python 3.12 #333

merged 9 commits into from
Jun 8, 2024

Conversation

pavel-kirienko
Copy link
Member

Fix #332

@pavel-kirienko pavel-kirienko self-assigned this Mar 16, 2024
@pavel-kirienko
Copy link
Member Author

@thirtytwobits it works fine on my local machine with Python 3.12.2, but fails in CI with an obscure internal error originating from the coverage package. There are a couple of odd reports related to it:

I suspect at the moment that this is not our problem; the latest CI run will reveal more info.

@pavel-kirienko
Copy link
Member Author

Hah! We're running an alpha build of Python: https://github.com/OpenCyphal/nunavut/actions/runs/8310952438/job/22744051997?pr=333#step:4:269

@thirtytwobits we're going to need a newer Python, our code is fine

@pavel-kirienko pavel-kirienko marked this pull request as ready for review March 17, 2024 01:00
@pavel-kirienko pavel-kirienko mentioned this pull request Mar 17, 2024
Closed
@thirtytwobits
Updating github actions
1743434 
Seeing if this fixes the EACCESS issues with the sonarqube step...
@thirtytwobits
Patch for issue #337
bb8ff57 
Applies workaround for GCC12 compiler bug
@thirtytwobits thirtytwobits force-pushed the issue/332_py3.12 branch 2 times, most recently from c23abf4 to 86757b1 Compare June 5, 2024 22:49
@thirtytwobits
Fix for issue #338
118e86e 
Fixing incorrect runtime asserts in generated C serialization code
@thirtytwobits
Fix for issue #339
f3333f6 
Disabling a GCC warning that appears broken in GCC12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@thirtytwobits thirtytwobits merged commit 6121909 into main Jun 8, 2024
183 checks passed
@thirtytwobits thirtytwobits deleted the issue/332_py3.12 branch June 8, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thirtytwobits thirtytwobits thirtytwobits approved these changes

Assignees

@pavel-kirienko pavel-kirienko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Python 3.12 support for generated python
2 participants
@pavel-kirienko @thirtytwobits