chore(deps): downgrade jsonschema dependency to 4.17 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This maintains compatibility with python 3.7 Signed-off-by: Alex Gerveshi <[email protected]>
epmog
approved these changes
Sep 29, 2023
jlangmann-aws
approved these changes
Sep 29, 2023
Honglichenn
pushed a commit
that referenced
this pull request
Jan 17, 2024
Problem: When running a Session as a different user on posix systems you will see a benign, but misleading, error message in the log that looks like: ``` rm: cannot remove '/tmp/openjd/session-name': Permission denied ``` This is caused by our two-phase cleanup of the Session working directory. We start with a cross-user 'rm -rf' to delete everything in the directory, and then do a same-user recursive delete. So, the working directory is getting cleaned up but there is this error in logs that is misleading. Solution: The `rm -rf` just needs to be changed to `rm -rf <dir>/*` from `rm -rf <dir>`. Signed-off-by: Daniel Neilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
deadline-cloudis locked to jsonschema-4.17 as it is the last version to support python 3.7.deadline-cloud-for-nukehas a dependency on this repo as well asdeadline-cloud, causing conflicting dependencies.What was the solution? (How)
Downgrade the jsonschema dependency to 4.17 to align with
deadline-cloudWhat is the impact of this change?
This repo is also locked to jsonschema-4.17 until we can determine a way to mix dependencies used by the adaptor (which can run python 3.9+) vs the child process being run (such as Nuke 13 which is using python 3.7)
How was this change tested?
Was this change documented?
No
Is this a breaking change?
Yes, dependency version is changing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.