Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ContentRazorHelperExtensions to more abstract project #17414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

infofromca
Copy link
Contributor

No description provided.

@Piedone
Copy link
Member

Piedone commented Feb 1, 2025

Can you explain the rationale?

@hishamco
Copy link
Member

hishamco commented Feb 1, 2025

IMHO we need to move such helpers in OC.xxx.Core - if exists -, otherwise OC.xxx.Abstractions this will avoid referencing modules on external projects if we need a simple IOrchardHelper method

@sebastienros
Copy link
Member

Can you update the release notes also in the PR to list it as a breaking change? Though technically we don't expect it to break actual websites (it's still technically possible).

@sebastienros
Copy link
Member

Also maybe we should do this #17189 at the same time.

This could be a non-breaking change by having the class defined in two namespaces, with the old one as obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants