Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal Frame 2 Undub - Patches update #448

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

MrWrightyLC
Copy link
Contributor

@MrWrightyLC MrWrightyLC commented Nov 20, 2024

  • The undub patch was updated a few months ago and with that update the CRC changed again, so this PR adds support for this new Undub v1.0.2 (1C6C1B71) basically using the same patches as Undub v1.0.1 (1C6C1DB6).
  • So the support for the old v1.0.1 is removed, in order not to fill this repository with unnecessary CRC's, leaving only the support for the most recent version of this romhack.
  • as well as this PR serves as a follow up of Remove a double speed fatal frame 2 60fps patch #424
    since that PR forgot to disable the broken 60fps patch for the Undub patch

i would also like to have the opinion of a moderator

1. I should remove support for the old undub patch v1.0.1 (1C6C1DB6) from Nov 1, 2022 and only support for the latest undub patch v1.0.2 (1C6C1B71) from May 17, 2024?

2. Or leave it as it is for possible players that are still using the old undub v1.0.1?

@MrWrightyLC MrWrightyLC marked this pull request as ready for review November 20, 2024 23:38
@MrWrightyLC
Copy link
Contributor Author

Hmmm I think it would be best to only leave support for the most recent version of a romhack like this, otherwise this repository would be filled with multiple unnecessary CRCs of the same game.
I will delete the old file, after all there are very few people who use romhacks.

@MrWrightyLC MrWrightyLC marked this pull request as draft November 21, 2024 03:29
@MrWrightyLC MrWrightyLC marked this pull request as ready for review November 21, 2024 03:41
adds patch support for undub v1.0.2
remove patch support for undub v1.0.1
and disable broken 60fps patch for undub
@F0bes
Copy link
Member

F0bes commented Nov 23, 2024

I should have commented out the patch instead of removing it. Can you just comment it out instead?

@MrWrightyLC
Copy link
Contributor Author

I should have commented out the patch instead of removing it. Can you just comment it out instead?

Done

@F0bes F0bes merged commit 5cc1d09 into PCSX2:main Nov 23, 2024
3 checks passed
@MrWrightyLC MrWrightyLC deleted the FF2-Undub-update branch November 23, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants