-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GH Action tests and CodeCov #99
Conversation
@jdebacker. These three test failures in the last three tests of the
|
I tried adding the
|
.github/workflows/build_and_test.yml
Outdated
@@ -1,7 +1,5 @@ | |||
name: Build and test [Python 3.9, 3.10] | |||
|
|||
name: Build and test | |||
on: [push, pull_request] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re my comments a few weeks ago about unnecessary compute time, from a read of the updated workflow docs, I think we should be able to condition tests to run only when relevant files are affected.
E.g., something like:
on:
[push, pull_request]:
paths:
- './ogusa/**.py'
- './tests/**.py'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdebacker. Yes. I'll add this. But we probably need to expand beyond the .py
files.
-
In the
./ogusa/
directory, we have all.py
files except for one.json
file. I think we need to add the.json
file to the directory tracking. -
In the
./tests/
directory, we probably also need to test changes in the.pkl
files and.csv
files in the./tests/test_io_data/
directory. -
In the main directory, we probably need to run the tests whenever
environment.yml
,pyproject.toml
,pytest.ini
, orsetup.py
changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 70.32% 78.70% +8.37%
==========================================
Files 22 11 -11
Lines 1365 850 -515
==========================================
- Hits 960 669 -291
+ Misses 405 181 -224
Flags with carried forward coverage won't be shown. Click here to find out more. |
LGTM, thanks @rickecon! Ready for this to be merged? |
@jdebacker. Let me do one last check of a couple things. I still have this white whale of trying to get the Windows tests working again. |
@jdebacker. This PR is ready for your final review. I have made all the changes I am going to make. I spent hours trying to get the |
@jdebacker. All tests passed locally on my machine.
|
This PR:
build_and_test.yml
so that those tests only run when one of those files is changed.deploy_docs.yml
anddocs_check.yml
, and limitsdocs_check.yml
to only run on pull requests.tax_functions.md
in order to test if the event triggers worked properly (yes, they worked)environment.yml
./tests/test_io_data/
file that used output from the taxcalc package. This package was recently updated. I also changed thetest_get_data()
test in thetest_get_micro_data.py
file because the new taxcalc data included four years instead of two years. In order to conserve repo memory footprint, we deleted the last two years of the output.cc: @jdebacker