Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastdds formula to 2.0.2 #79

Merged
merged 2 commits into from
May 22, 2023

Conversation

ThomasDebrunner
Copy link
Member

@ThomasDebrunner ThomasDebrunner commented Nov 5, 2021

This upgrades the fast-rtps (now called fast-dds) to v2.4.0
This was made in an effort to make the px4-dev install natively on Apple Silicon M1

Additional changes:

  • fast dds now depends on foonathan-memory. This adds a formula for that
  • fastddsgen (formerly fastrtpsgen) is now its own repository. This adds an explicit formula for this

@TSC21
Copy link
Member

TSC21 commented Nov 5, 2021

We do not support FastDDS 2.4.0. Or we might but this will have to go through extensive testing. Also fastddsgen (2.0.0 and above) only generates code for DDS API, not RTPS API, which we do require (https://github.com/eProsima/Fast-DDS-Gen/releases/tag/v2.0.0).
I would start by making sure we are installing the base version we support (FastDDS 2.0.2 and FastRTPSGen 1.0.4). And as soon as it makes sense we move to newer versions.
Also FastDDSGen will not be required as soon as we move to Micro XRCE-DDS.

@ThomasDebrunner ThomasDebrunner changed the title Update fastdds formula to 2.4.0 Update fastdds formula to 2.0.2 Nov 7, 2021
@ThomasDebrunner
Copy link
Member Author

@TSC21 Understood! I changed the target version to fastdds 2.0.2 and fastddsgen to 1.0.4
The version changes were trivial here, since the dependency changes cam in with fastdds 2.x

@wyager
Copy link

wyager commented Sep 5, 2022

Can this be merged? cf #77

@ThomasDebrunner ThomasDebrunner merged commit 688fc3d into PX4:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants