Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple M1 support: Disable ncurses frontend in kconfig-frontends #80

Merged
merged 3 commits into from
May 22, 2023

Conversation

ThomasDebrunner
Copy link
Member

There are some issues compiling kconfig-frontends with the ncurses frontend on Apple Silicon. For now, this PR disables the compilation of that specific frontent on arm.

This is on top of #79
Both PRs together should make the px4-dev formula now succeed on Apple Silicon

@ben-xD
Copy link

ben-xD commented May 20, 2022

Hey @ThomasDebrunner, this MR looks very useful. Is there anything delaying this MR from merging? Thanks

@ThomasDebrunner
Copy link
Member Author

ThomasDebrunner commented May 24, 2022

@ben-xD I think that's good to go. Has been 6 months since I did this, can you confirm it stil works on a fresh system? Tbh, there are probably some more dependencies in there that are no longer required
@TSC21 Can you review that?

@Sitin
Copy link

Sitin commented Jun 27, 2022

Any progress with this?

@4bdul4ziz
Copy link

Hey, is there a way where I can manually download this pr despite it not being merged with the official formula?
Many thanks.

@davids5
Copy link
Member

davids5 commented Dec 7, 2022

git checkout -b ThomasDebrunner-m1-support master
git pull [email protected]:ThomasDebrunner/homebrew-px4.git m1-support

git checkout -b ThomasDebrunner-m1-support master
git pull [email protected]:ThomasDebrunner/homebrew-px4.git m1-support

@mengchaoheng
Copy link

How to use this? on the follow step by guiden, which step I should change?

brew tap PX4/px4
brew install px4-dev
brew install --cask temurin
brew install --cask xquartz
brew install px4-sim-gazebo

@mengchaoheng
Copy link

so we don't need the rosetta? @ThomasDebrunner

@mengchaoheng
Copy link

==> Fetching osrf/simulation/ignition-common3
==> Downloading https://github.com/gazebosim/gz-common/commit/d6024ce4acd3a961e3d026e5bc1bfbcb1e4b99e6.patch?full_index=1
Error: px4-sim-gazebo: Failed to download resource "ignition-common3--patch"
Failure while executing; `/usr/bin/env /opt/homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.0.15\ \(Macintosh\;\ arm64\ Mac\ OS\ X\ 12.3\)\ curl/7.79.1 --header Accept-Language:\ en --retry 3 --fail --location --silent --head --request GET https://github.com/gazebosim/gz-common/commit/d6024ce4acd3a961e3d026e5bc1bfbcb1e4b99e6.patch\?full_index=1 --http1.1` exited with 35. Here's the output:
curl: (35) error:02FFF020:system library:func(4095):Broken pipe


➜  ~ 

@farhangnaderi
Copy link

I can confirm this is working. Tried with jmavsim. Gazebo-classic has cv2 issue (not detecting it) which trying to figure out.

@ThomasDebrunner
Copy link
Member Author

@farhangnaderi I am not maintaining this anymore, is it worth to merge this PR now and fix remaining things in other PRs?

@farhangnaderi
Copy link

farhangnaderi commented May 22, 2023

It seems ok to me Thomas.
For instance, another issue is that jMavsim has to be pointed to x64 version of openjdk not arm64 so that a library is going to work.

export JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home

I guess you are right, better to merge it as it is and leave the rest for future or we temporarily document it somewhere.
Native builds on arm64 are extremely power-saving and fast. :)

@ThomasDebrunner ThomasDebrunner merged commit caf9f79 into PX4:master May 22, 2023
@farhangnaderi
Copy link

@SalimTerryLi FYI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants