fix: Move react strict dependencies #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strict dependencies caused installation react version doesn't match Signed-off-by: Tiago Barbosa <[email protected]>
regenerating yarn.lock Signed-off-by: Tiago Barbosa <[email protected]>
t1agob
added a commit
that referenced
this pull request
Dec 10, 2023
* chore(dependencies): ⬆️ add support for react 18+ (#43) * chore(dependencies): Bump up backstage versions (#44) * chore(dependencies): 📌 upgrade backstage dependencies * docs(docs): 📝 simplify readme file and point to full documentation (#47) * chore(deps): bump @adobe/css-tools from 4.3.1 to 4.3.2 (#48) * fix: Move react strict dependencies (#49) Signed-off-by: Tiago Barbosa <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
packages.json defines react dependencies as strict dependencies instead of peerDependencies and devDependencies. This prevents the plugin to use the version of React define by the installation and instead forced the one used in the project.
This causes the plugin installation to fail in configurations where the React version doesn't match the one defined in the plugin.
This PR moves React dependencies into peerDependencies to allow the plugin to use the version defined in the Backstage configuration and devDependencies to allow tests to run successfully.
It also upgrades Backstage packages to the latest version.
Type of change
Checklist
If this is a breaking change 👇
Acknowledgement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.