Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace All Doors and Windoors Access with Mapping_Helpers Access. #22168

Merged
merged 19 commits into from
Sep 19, 2023

Conversation

Venuska1117
Copy link
Contributor

@Venuska1117 Venuska1117 commented Aug 30, 2023

(Please TM it just in case some access will break on way.)

What Does This PR Do

It Run already provided files from #21565 made by warriorstar-orion (with are doors and windoors access replacement)

fixes #22124
fixes #22125

Why It's Good For The Game

Replace var edited access with map access helpers.

Images of changes

Some photo from brig.
image

Testing

Runned UpdatePaths, checked in editor if it worked (it worked) and do test run to see for errors.

Changelog

🆑 warriorstar-orion, Venuska1117
tweak: Change Doors and Windoors var edited access to helper access.
tweak: All Nameless windoors now have names.
add: Delta Medbay now allow people exit clonner with directional access.
/:cl:

it replace a lot of files.
@Venuska1117 Venuska1117 marked this pull request as draft August 30, 2023 12:31
for some reason, running doors before windoors crate doors access on windors, so windoors need be used first before door one.
@Venuska1117 Venuska1117 marked this pull request as ready for review August 30, 2023 12:41
@Venuska1117 Venuska1117 changed the title Replace All Doors and Windoors Access with Map_Helper Access. Replace All Doors and Windoors Access with Mapping_Helpers Access. Aug 30, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added DeltaStation This PR will edit the map DeltaStation (Kerberos) MetaStation This PR will edit the map MetaStation (Cerebron) CereStation This PR edits the map CereStation (Farragus) BoxStation This PR will edit the map BoxStation (Cyberiad) -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map labels Aug 31, 2023
- Replace TOX access on delta RnD windoors to RESEARCH access.
- Replace RESEARCH access on delta xenobio windoors to XENOBIO access.
- Remove QM access on Cerestation Captain windoors. (he will be member of command anyway in upcomming PR)
@SteelSlayer SteelSlayer added the Refactor This PR will clean up the code but have the same ingame outcome label Sep 5, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Requested This PR has a pending testmerge request -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 5, 2023
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 10, 2023
- Manually removed QM access from cerestation captain windoors.
- Manually changed access'es on delta science departament.
- Manually changed airlock access to windoor access on Metastation.
@SteelSlayer SteelSlayer removed the Merge Conflict This PR is merge conflicted label Sep 11, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added [MQL] MetaStation Testmerge Active This PR is currently testmerged on production and removed Testmerge Active This PR is currently testmerged on production labels Sep 11, 2023
Copy link
Member

@S34NW S34NW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
A few examples of "custom placement" named windoors on various maps, these need cleaning up or having an autoname helper on them.

I'd go over every windoor making sure the helpers on them are directional and none of them are called .custom placement, you can do this in SDMM by right clicking
image

_maps/map_files/generic/centcomm.dmm Show resolved Hide resolved
_maps/map_files/MetaStation/MetaStation.dmm Show resolved Hide resolved
_maps/map_files/cyberiad/cyberiad.dmm Show resolved Hide resolved
@Venuska1117 Venuska1117 marked this pull request as draft September 16, 2023 12:47
- Metastation, Cerestation, Cyberiad and Delta got Mule_bot access swapped from airlock to windoor access helper.
- Changed lavaland_biodome_beach bar windoor access from airlock to windoor access helper.
- Changed admin_armory windoors got changed from airlock to windoor access helper.
- Now every windoor is named, so there is no more ".custom placement"
- Change some access windoors access helpers from airlock to windoor type.
- Change all "mining" access to "mining_station" access.
@Venuska1117 Venuska1117 marked this pull request as ready for review September 18, 2023 08:19
Copy link
Member

@S34NW S34NW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Have requested it gets TMd for a round to ensure sanity before fullmerge. Any follow-up fixes can be prioritized if they arise after merge.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge Testmerge Active This PR is currently testmerged on production and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 19, 2023
@S34NW S34NW merged commit 683c9f9 into ParadiseSS13:master Sep 19, 2023
15 checks passed
@Venuska1117 Venuska1117 deleted the doors-and-windoors-(updatepath) branch September 19, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge BoxStation This PR will edit the map BoxStation (Cyberiad) CereStation This PR edits the map CereStation (Farragus) DeltaStation This PR will edit the map DeltaStation (Kerberos) Map Edit This PR will modify a map MetaStation This PR will edit the map MetaStation (Cerebron) Refactor This PR will clean up the code but have the same ingame outcome Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request
Projects
None yet
4 participants