Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TGUI] Wall safes/secure briefcases #22447

Merged
merged 13 commits into from
Sep 25, 2023
Merged

Conversation

Contrabang
Copy link
Contributor

@Contrabang Contrabang commented Sep 17, 2023

What Does This PR Do

Makes Wall safes/secure briefcases into TGUI and cleans up the code around them. Screwdrivering them now make a noise. It allows for typing on the keypad, or clicking on the display box, and typing in with your keyboard.

Why It's Good For The Game

Advances https://github.com/orgs/ParadiseSS13/projects/4

Images of changes

DMFS8DYNrD.mp4

Testing

Emagged it, hacked it, typed into it, clicked all the buttons on it, crashed my games a few times (fixed).

Changelog

🆑
tweak: Wall safes and secure briefcases are now TGUI
/:cl:

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 17, 2023
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Sep 17, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 18, 2023
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 19, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Sep 19, 2023
Copy link
Contributor

@Sirryan2002 Sirryan2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really solid code

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Sep 20, 2023
@github-actions github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Sep 24, 2023
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Sep 25, 2023
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Sep 25, 2023
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legume to me

@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Sep 25, 2023
@lewcc lewcc merged commit 23c4e49 into ParadiseSS13:master Sep 25, 2023
15 checks passed
@Contrabang Contrabang deleted the tguisafe branch September 26, 2023 00:22
Furrior pushed a commit to ss220club/Paradise-SS220 that referenced this pull request Sep 26, 2023
* bam

* fix this

* fix

* thing

* prettier

* tgui

* Update code/game/objects/items/weapons/storage/secure.dm

Co-authored-by: Luc <[email protected]>

* guh

---------

Co-authored-by: Luc <[email protected]>
Furrior pushed a commit to ss220club/Paradise-SS220 that referenced this pull request Oct 22, 2023
* bam

* fix this

* fix

* thing

* prettier

* tgui

* Update code/game/objects/items/weapons/storage/secure.dm

Co-authored-by: Luc <[email protected]>

* guh

---------

Co-authored-by: Luc <[email protected]>
BR54FF pushed a commit to BR54FF/Paradise-SS220 that referenced this pull request Oct 23, 2023
* bam

* fix this

* fix

* thing

* prettier

* tgui

* Update code/game/objects/items/weapons/storage/secure.dm

Co-authored-by: Luc <[email protected]>

* guh

---------

Co-authored-by: Luc <[email protected]>
BR54FF pushed a commit to BR54FF/Paradise-SS220 that referenced this pull request Oct 23, 2023
* bam

* fix this

* fix

* thing

* prettier

* tgui

* Update code/game/objects/items/weapons/storage/secure.dm

Co-authored-by: Luc <[email protected]>

* guh

---------

Co-authored-by: Luc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants