-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TGUI] Wall safes/secure briefcases #22447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrabang
commented
Sep 17, 2023
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
TGUI
This PR modifies TGUI, will conflict
-Status: Awaiting approval
This PR is waiting for approval internally
and removed
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
labels
Sep 18, 2023
ParadiseSS13-Bot
added
-Status: Awaiting review
This PR is awaiting review from the review team
and removed
-Status: Awaiting approval
This PR is waiting for approval internally
labels
Sep 19, 2023
Sirryan2002
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really solid code
ParadiseSS13-Bot
added
-Status: Awaiting merge
This PR is ready for merge
and removed
-Status: Awaiting review
This PR is awaiting review from the review team
labels
Sep 20, 2023
github-actions
bot
added
Merge Conflict
This PR is merge conflicted
and removed
Merge Conflict
This PR is merge conflicted
labels
Sep 24, 2023
lewcc
reviewed
Sep 25, 2023
Co-authored-by: Luc <[email protected]>
lewcc
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
legume to me
Furrior
pushed a commit
to ss220club/Paradise-SS220
that referenced
this pull request
Sep 26, 2023
* bam * fix this * fix * thing * prettier * tgui * Update code/game/objects/items/weapons/storage/secure.dm Co-authored-by: Luc <[email protected]> * guh --------- Co-authored-by: Luc <[email protected]>
Furrior
pushed a commit
to ss220club/Paradise-SS220
that referenced
this pull request
Oct 22, 2023
* bam * fix this * fix * thing * prettier * tgui * Update code/game/objects/items/weapons/storage/secure.dm Co-authored-by: Luc <[email protected]> * guh --------- Co-authored-by: Luc <[email protected]>
BR54FF
pushed a commit
to BR54FF/Paradise-SS220
that referenced
this pull request
Oct 23, 2023
* bam * fix this * fix * thing * prettier * tgui * Update code/game/objects/items/weapons/storage/secure.dm Co-authored-by: Luc <[email protected]> * guh --------- Co-authored-by: Luc <[email protected]>
BR54FF
pushed a commit
to BR54FF/Paradise-SS220
that referenced
this pull request
Oct 23, 2023
* bam * fix this * fix * thing * prettier * tgui * Update code/game/objects/items/weapons/storage/secure.dm Co-authored-by: Luc <[email protected]> * guh --------- Co-authored-by: Luc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Makes Wall safes/secure briefcases into TGUI and cleans up the code around them. Screwdrivering them now make a noise. It allows for typing on the keypad, or clicking on the display box, and typing in with your keyboard.Why It's Good For The Game
Advances https://github.com/orgs/ParadiseSS13/projects/4Images of changes
DMFS8DYNrD.mp4
Testing
Emagged it, hacked it, typed into it, clicked all the buttons on it, crashed my games a few times (fixed).
Changelog
🆑
tweak: Wall safes and secure briefcases are now TGUI
/:cl: