Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/ci: enforce mapload in Initialize args #26878

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
2 changes: 1 addition & 1 deletion code/_onclick/hud/picture_in_picture.dm
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
var/mutable_appearance/standard_background
var/const/max_dimensions = 10

/atom/movable/screen/movable/pic_in_pic/Initialize()
/atom/movable/screen/movable/pic_in_pic/Initialize(mapload)
. = ..()
make_backgrounds()

Expand Down
4 changes: 2 additions & 2 deletions code/_onclick/hud/plane_master.dm
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
mymob.overlay_fullscreen("lighting_backdrop_lit", /atom/movable/screen/fullscreen/stretch/lighting_backdrop/lit)
mymob.overlay_fullscreen("lighting_backdrop_unlit", /atom/movable/screen/fullscreen/stretch/lighting_backdrop/unlit)

/atom/movable/screen/plane_master/lighting/Initialize()
/atom/movable/screen/plane_master/lighting/Initialize(mapload)
. = ..()
add_filter("emissives", 1, alpha_mask_filter(render_source = EMISSIVE_RENDER_TARGET, flags = MASK_INVERSE))

Expand All @@ -73,7 +73,7 @@
mouse_opacity = MOUSE_OPACITY_TRANSPARENT
render_target = EMISSIVE_RENDER_TARGET

/atom/movable/screen/plane_master/emissive/Initialize()
/atom/movable/screen/plane_master/emissive/Initialize(mapload)
. = ..()
add_filter("em_block_masking", 1, color_matrix_filter(GLOB.em_mask_matrix))

Expand Down
2 changes: 1 addition & 1 deletion code/datums/status_effects/debuffs.dm
Original file line number Diff line number Diff line change
Expand Up @@ -1347,7 +1347,7 @@
icon_state = "rift"
color = "red"

/obj/effect/bubblegum_warning/Initialize()
/obj/effect/bubblegum_warning/Initialize(mapload)
. = ..()
addtimer(CALLBACK(src, PROC_REF(slap_someone)), 2.5 SECONDS) //A chance to run away

Expand Down
2 changes: 1 addition & 1 deletion code/game/gamemodes/miniantags/abduction/abduction_gear.dm
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ CONTENTS:
item_state = "abductor_headset"
ks2type = /obj/item/encryptionkey/heads/captain

/obj/item/radio/headset/abductor/Initialize()
/obj/item/radio/headset/abductor/Initialize(mapload)
. = ..()
make_syndie() // Why the hell is this a proc why cant it just be a subtype

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
var/obj/machinery/computer/camera_advanced/abductor/camera
var/list/datum/icon_snapshot/disguises = list()

/obj/machinery/abductor/console/Initialize()
/obj/machinery/abductor/console/Initialize(mapload)
..()
return INITIALIZE_HINT_LATELOAD

Expand Down
6 changes: 3 additions & 3 deletions code/game/gamemodes/nuclear/nuclearbomb.dm
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ GLOBAL_VAR(bomb_set)
extended = FALSE
anchored = FALSE

/obj/machinery/nuclearbomb/Initialize()
/obj/machinery/nuclearbomb/Initialize(mapload)
. = ..()
r_code = rand(10000, 99999) // Creates a random code upon object spawn.
wires = new/datum/wires/nuclearbomb(src)
Expand All @@ -87,7 +87,7 @@ GLOBAL_VAR(bomb_set)
radio.follow_target = src
radio.config(list("Special Ops" = 0))

/obj/machinery/nuclearbomb/syndicate/Initialize()
/obj/machinery/nuclearbomb/syndicate/Initialize(mapload)
. = ..()
wires.labelled = FALSE
ADD_TRAIT(src, TRAIT_OBSCURED_WIRES, ROUNDSTART_TRAIT)
Expand Down Expand Up @@ -793,7 +793,7 @@ GLOBAL_VAR(bomb_set)
training = TRUE
sprite_prefix = "t_"

/obj/machinery/nuclearbomb/training/Initialize()
/obj/machinery/nuclearbomb/training/Initialize(mapload)
. = ..()
r_code = 11111 //Uuh.. one!

Expand Down
2 changes: 1 addition & 1 deletion code/game/gamemodes/wizard/magic_tarot.dm
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@
pixel_y = 20
duration = 1.5 SECONDS

/obj/effect/temp_visual/tarot_preview/Initialize(atom/mapload, new_icon_state)
/obj/effect/temp_visual/tarot_preview/Initialize(mapload, new_icon_state)
. = ..()
if(new_icon_state)
icon_state = "tarot_[new_icon_state]"
Expand Down
8 changes: 4 additions & 4 deletions code/game/machinery/autolathe.dm
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
var/list/categories = list("Tools", "Electronics", "Construction", "Communication", "Security", "Machinery", "Medical", "Miscellaneous", "Dinnerware", "Imported")
var/board_type = /obj/item/circuitboard/autolathe

/obj/machinery/autolathe/Initialize()
/obj/machinery/autolathe/Initialize(mapload)
. = ..()
AddComponent(/datum/component/material_container, list(MAT_METAL, MAT_GLASS), _show_on_examine=TRUE, _after_insert=CALLBACK(src, PROC_REF(AfterMaterialInsert)))
component_parts = list()
Expand All @@ -56,7 +56,7 @@
files = new /datum/research/autolathe(src)
matching_designs = list()

/obj/machinery/autolathe/upgraded/Initialize()
/obj/machinery/autolathe/upgraded/Initialize(mapload)
. = ..()
component_parts = list()
component_parts += new board_type(null)
Expand All @@ -67,7 +67,7 @@
component_parts += new /obj/item/stack/sheet/glass(null)
RefreshParts()

/obj/machinery/autolathe/upgraded/gamma/Initialize()
/obj/machinery/autolathe/upgraded/gamma/Initialize(mapload)
. = ..()
files = new /datum/research/autolathe/gamma(src)
adjust_hacked(TRUE)
Expand Down Expand Up @@ -522,7 +522,7 @@
name = "syndicate autolathe"
board_type = /obj/item/circuitboard/autolathe/syndi

/obj/machinery/autolathe/syndicate/Initialize()
/obj/machinery/autolathe/syndicate/Initialize(mapload)
. = ..()
files = new /datum/research/autolathe/syndicate(src)

Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/computer/atmos_controllers.dm
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ GLOBAL_LIST_EMPTY(gas_sensors)
/// List of sensor names to cache lists used in the display TGUI
var/tmp/list/sensor_name_data_map = list()

/obj/machinery/computer/general_air_control/Initialize()
/obj/machinery/computer/general_air_control/Initialize(mapload)
..()
return INITIALIZE_HINT_LATELOAD // Do all our work in here

Expand Down
6 changes: 3 additions & 3 deletions code/game/machinery/computer/camera_console.dm
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
/obj/machinery/computer/security/ui_host()
return parent ? parent : src

/obj/machinery/computer/security/Initialize()
/obj/machinery/computer/security/Initialize(mapload)
. = ..()
// Initialize map objects
map_name = "camera_console_[UID()]_map"
Expand Down Expand Up @@ -230,7 +230,7 @@
/// Used to detect how many video cameras are active
var/feeds_on = 0

/obj/machinery/computer/security/telescreen/entertainment/Initialize()
/obj/machinery/computer/security/telescreen/entertainment/Initialize(mapload)
. = ..()
set_light(1, LIGHTING_MINIMUM_POWER) //so byond doesnt cull, and we get an emissive appearance

Expand Down Expand Up @@ -305,7 +305,7 @@
network = list()
circuit = /obj/item/circuitboard/camera/engineering

/obj/machinery/computer/security/engineering/Initialize()
/obj/machinery/computer/security/engineering/Initialize(mapload)
. = ..()
network = list()
var/area/console_area = get_area(src)
Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/computer/computer.dm
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/// Are we forcing the icon to be represented in a no-power state?
var/force_no_power_icon_state = FALSE

/obj/machinery/computer/Initialize()
/obj/machinery/computer/Initialize(mapload)
. = ..()
power_change()
update_icon()
Expand Down
4 changes: 2 additions & 2 deletions code/game/machinery/computer/crew_monitoring.dm
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
circuit = /obj/item/circuitboard/crew
var/datum/ui_module/crew_monitor/crew_monitor

/obj/machinery/computer/crew/Initialize()
/obj/machinery/computer/crew/Initialize(mapload)
. = ..()
crew_monitor = new(src)

Expand Down Expand Up @@ -39,6 +39,6 @@
name = "advanced crew monitoring computer"
desc = "Used to monitor active health sensors built into most of the crew's uniforms across multiple sectors."

/obj/machinery/computer/crew/advanced/Initialize()
/obj/machinery/computer/crew/advanced/Initialize(mapload)
. = ..()
crew_monitor.is_advanced = TRUE
2 changes: 1 addition & 1 deletion code/game/machinery/computer/medical_records.dm
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

light_color = LIGHT_COLOR_DARKBLUE

/obj/machinery/computer/med_data/Initialize()
/obj/machinery/computer/med_data/Initialize(mapload)
. = ..()
field_edit_questions = list(
// General
Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/computer/message_monitor.dm
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

light_color = LIGHT_COLOR_DARKGREEN

/obj/machinery/computer/message_monitor/Initialize()
/obj/machinery/computer/message_monitor/Initialize(mapload)
..()
return INITIALIZE_HINT_LATELOAD // Give the message server time to initialize

Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/doors/airlock.dm
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ GLOBAL_LIST_EMPTY(airlock_emissive_underlays)
return TRUE
return FALSE

/obj/machinery/door/airlock/Initialize()
/obj/machinery/door/airlock/Initialize(mapload)
. = ..()
/*
About the new airlock wires panel:
Expand Down
10 changes: 5 additions & 5 deletions code/game/machinery/doors/airlock_types.dm
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@
glass = TRUE
opacity = FALSE

/obj/machinery/door/airlock/centcom/glass/Initialize()
/obj/machinery/door/airlock/centcom/glass/Initialize(mapload)
. = ..()
update_icon()

Expand Down Expand Up @@ -519,7 +519,7 @@
/// Inner airlock material (Glass, plasteel)
var/stealth_airlock_material = null

/obj/machinery/door/airlock/cult/Initialize()
/obj/machinery/door/airlock/cult/Initialize(mapload)
. = ..()
icon = GET_CULT_DATA(airlock_runed_icon_file, initial(icon))
overlays_file = GET_CULT_DATA(airlock_runed_overlays_file, initial(overlays_file))
Expand Down Expand Up @@ -584,7 +584,7 @@
glass = TRUE
opacity = FALSE

/obj/machinery/door/airlock/cult/glass/Initialize()
/obj/machinery/door/airlock/cult/glass/Initialize(mapload)
. = ..()
update_icon()

Expand All @@ -597,7 +597,7 @@
assemblytype = /obj/structure/door_assembly/door_assembly_cult/unruned
openingoverlaytype = /obj/effect/temp_visual/cult/door/unruned

/obj/machinery/door/airlock/cult/unruned/Initialize()
/obj/machinery/door/airlock/cult/unruned/Initialize(mapload)
. = ..()
icon = GET_CULT_DATA(airlock_unruned_icon_file, initial(icon))
overlays_file = GET_CULT_DATA(airlock_unruned_overlays_file, initial(overlays_file))
Expand All @@ -610,7 +610,7 @@
glass = TRUE
opacity = FALSE

/obj/machinery/door/airlock/cult/unruned/glass/Initialize()
/obj/machinery/door/airlock/cult/unruned/glass/Initialize(mapload)
. = ..()
update_icon()

Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/dye_generator.dm
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
idle_power_consumption = 40
var/dye_color = "#FFFFFF"

/obj/machinery/dye_generator/Initialize()
/obj/machinery/dye_generator/Initialize(mapload)
. = ..()
power_change()

Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/flasher.dm
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
var/base_state = "mflash"
anchored = TRUE

/obj/machinery/flasher/Initialize()
/obj/machinery/flasher/Initialize(mapload)
. = ..()
update_icon()

Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/floodlight.dm
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/obj/machinery/floodlight/get_cell()
return cell

/obj/machinery/floodlight/Initialize()
/obj/machinery/floodlight/Initialize(mapload)
. = ..()
cell = new(src)
mapVarInit()
Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/shieldgen.dm
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
/// The rune that created the shield itself. Used to delete the rune when the shield is destroyed.
var/obj/effect/rune/parent_rune

/obj/machinery/shield/cult/barrier/Initialize()
/obj/machinery/shield/cult/barrier/Initialize(mapload)
. = ..()
invisibility = INVISIBILITY_MAXIMUM

Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/status_display.dm
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ GLOBAL_LIST_EMPTY(status_displays)
var/index1
var/index2

/obj/machinery/status_display/Initialize()
/obj/machinery/status_display/Initialize(mapload)
. = ..()
GLOB.status_displays |= src
update_icon(UPDATE_OVERLAYS)
Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/suit_storage_unit.dm
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@
helmet_type = /obj/item/clothing/head/radiation
storage_type = /obj/item/geiger_counter

/obj/machinery/suit_storage_unit/Initialize()
/obj/machinery/suit_storage_unit/Initialize(mapload)
. = ..()

component_parts = list()
Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/teleporter.dm
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
/// When the teleporter is upgraded, it can lock onto beacons directly, rather than turfs. This is the variable for it.
var/advanced_beacon_locking = FALSE

/obj/machinery/computer/teleporter/Initialize()
/obj/machinery/computer/teleporter/Initialize(mapload)
. = ..()
link_power_station()
update_icon()
Expand Down
2 changes: 1 addition & 1 deletion code/game/machinery/turret_control.dm
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
A.turret_controls -= src
return ..()

/obj/machinery/turretid/Initialize()
/obj/machinery/turretid/Initialize(mapload)
. = ..()
if(!control_area)
control_area = get_area(src)
Expand Down
2 changes: 1 addition & 1 deletion code/game/mecha/mech_bay.dm
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@
)
return data

/obj/machinery/computer/mech_bay_power_console/Initialize()
/obj/machinery/computer/mech_bay_power_console/Initialize(mapload)
reconnect()
update_icon()
return ..()
2 changes: 1 addition & 1 deletion code/game/mecha/mecha.dm
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@

hud_possible = list (DIAG_STAT_HUD, DIAG_BATT_HUD, DIAG_MECH_HUD, DIAG_TRACK_HUD)

/obj/mecha/Initialize()
/obj/mecha/Initialize(mapload)
. = ..()
icon_state += "-open"
add_radio()
Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/effects/decals/Cleanable/fuel.dm
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
icon_state = "mustard"
anchored = FALSE

/obj/effect/decal/cleanable/liquid_fuel/flamethrower_fuel/Initialize(newLoc, amt = 1, d = 0)
/obj/effect/decal/cleanable/liquid_fuel/flamethrower_fuel/Initialize(mapload, newLoc, amt = 1, d = 0)
dir = d //Setting this direction means you won't get torched by your own flamethrower.
. = ..()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
canSmoothWith = list(SMOOTH_GROUP_CLEANABLE_DIRT, SMOOTH_GROUP_WALLS)
mouse_opacity = FALSE

/obj/effect/decal/cleanable/dirt/Initialize()
/obj/effect/decal/cleanable/dirt/Initialize(mapload)
. = ..()
QUEUE_SMOOTH_NEIGHBORS(src)
if(smoothing_flags & (SMOOTH_CORNERS|SMOOTH_BITMASK))
Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/effects/effect_system/effects_foam.dm
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@
max_integrity = 20
var/metal = METAL_FOAM_ALUMINUM

/obj/structure/foamedmetal/Initialize()
/obj/structure/foamedmetal/Initialize(mapload)
. = ..()
recalculate_atmos_connectivity()

Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/effects/spawners/airlock_spawner.dm
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ This spawner places pipe leading up to the interior door, you will need to finis
var/one_door_interior //For square airlocks, if you set this then a) only one door will spawn, and b) you can choose if the door should go opposite to how it normally goes. Please use the define
var/one_door_exterior //See above

/obj/effect/spawner/airlock/Initialize()
/obj/effect/spawner/airlock/Initialize(mapload)
..()
forceMove(locate(x + 1, y + 1, z)) //Needs to move because our icon_state implies we are one turf to the northeast, when we're not
opposite_interior_direction = turn(interior_direction, 180) //Do it this way (instead of setting it directly) to avoid code mishaps
Expand Down
2 changes: 1 addition & 1 deletion code/game/objects/effects/spawners/random/misc_spawners.dm
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
)
record_spawn = TRUE

/obj/effect/spawner/random/dice/Initialize()
/obj/effect/spawner/random/dice/Initialize(mapload)
. = ..()
spawn_loot_count = rand(1, 2)

Expand Down
Loading