Replaced YAPF with black #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAPF was giving us headaches as the reformattings were neither intuitive nor predictable. We wanted to upgrade for Python 3.11, and tried to upgrade YAPF to the latest version. As it caused a lot of reformatting, we decided to drop YAPF and replace it with black. Black seems a bit more stable, and subjectively gives us nicer formatting.
mristin
added a commit
that referenced
this pull request
Oct 4, 2023
We replaced YAPF with black in #265, but forgot to update the comments to turn formatting off on a small number of snippets where the default formatting was unreadable. In this patch, we replaced the comments to instruct black to skip these snippets.
mristin
added a commit
that referenced
this pull request
Oct 4, 2023
We replaced YAPF with black in #265, but forgot to update the comments to turn formatting off on a small number of snippets where the default formatting was unreadable. In this patch, we replaced the comments to instruct black to skip these snippets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAPF was giving us headaches as the reformattings were neither intuitive nor predictable. We wanted to upgrade for Python 3.11, and tried to upgrade YAPF to the latest version. As it caused a lot of reformatting, we decided to drop YAPF and replace it with black.
Black seems a bit more stable, and subjectively gives us nicer formatting.