Fix broken link to met-data documentation #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dlebauer
commented
Sep 11, 2024
•
dlebauer
commented
- fix broken link
- Updated pecan_standards section to standardize heading level, e.g. 'input standards' and 'output standards' are now at the same level, and will show up in TOC on left. Previously the entire page had the title "Time Standards" which was confusing
infotroph
reviewed
Sep 11, 2024
modules/data.atmosphere/README.md
Outdated
| @@ -32,7 +32,7 @@ The PEcAn.data.atmosphere package is 'standalone'. | |||
|
|
|||
| ## PEcAn variable names | |||
|
|
|||
| See https://pecanproject.github.io/pecan-documentation/latest/met-data.html | |||
| For the most updated list, see https://pecanproject.github.io/pecan-documentation/develop/time-standard.html#input-standards | |||
There was a problem hiding this comment.
I think links in most other docs point to the main branch (confusingly latest on github.io and main on github.com). Is it important for this one to be the develop version?
There was a problem hiding this comment.
Ah, I assumed latest == develop. Happy to change, but it seems that main can be years out of date and in practice it seems most people use develop. Probably more trouble than it is worth to parameterize this.
There was a problem hiding this comment.
fixed, I'm not 100% if I understand correctly, but only master and develop and other branch names in the URL point to an existing page in the documentation.
Updated so that indents are consistent, e.g. 'input standards' and 'output standards' are at the same level, and will show up in TOC on left
dlebauer
commented
Sep 11, 2024
dlebauer
commented
Sep 11, 2024
dlebauer
commented
Sep 11, 2024
infotroph
reviewed
Sep 11, 2024
Co-authored-by: David LeBauer <[email protected]>
infotroph
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.