Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtree sync 2 #2

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Subtree sync 2 #2

wants to merge 25 commits into from

Conversation

danwahl
Copy link

@danwahl danwahl commented Jan 17, 2025

No description provided.

marioprats and others added 24 commits February 22, 2025 16:24
* use slik as the pose IK solver in all configs, remove deps to trac_ik

* remove unused kinematics.yaml files

* rename slik -> pose_ik
These new behaviors expose more planning parameters for the Pro RRT
Connect planner.

Replace:
* `SetupMTCMoveToPose` -> `SetupMTCPlanToPose`
* `SetupMTCMoveToJointState` -> `SetupMTCPlanToJointState`

Update planning configuration ports:
* Remove deprecated `planner_interface` port.
* use `keep_orientation` and `keep_orientation_tolerance` ports instead
  of `constraints` port
* Lower `link_padding` where it causes self collisions
Signed-off-by: Paul Gesel <[email protected]>
@danwahl
Copy link
Author

danwahl commented Feb 22, 2025

@MikeWrock I think this is back up-to-date with example_ws. Not 100% if I'm remembering the correct procedure, but I tried to do it in such a way that we:

  1. Preserve local history in this repo
  2. Match all the commits in example_ws that are relevant to this subtree

Which basically involved adding example_ws as a remote and then the following (assuming 4f40bad^..1ce3631 is the range of new commits in example_ws that we want to grab):

git log --reverse --format="%H" 4f40bad^..1ce3631 -- src/moveit_pro_kinova_configs > /tmp/commits_to_pick.txt
git cherry-pick --strategy=recursive --strategy-option=subtree=src/moveit_pro_kinova_configs -m 1 $(cat /tmp/commits_to_pick.txt)

Let me know if this makes sense, or if I'm missing something, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants