Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add tool in world srv #71

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add add tool in world srv #71

merged 1 commit into from
Nov 14, 2024

Conversation

dyackzan
Copy link
Contributor

No description provided.

@dyackzan dyackzan requested a review from marioprats October 29, 2024 10:42
@dyackzan dyackzan added the breaking change Breaks behavior or site config APIs and requires migration label Oct 29, 2024
Copy link
Contributor

@marioprats marioprats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! but maybe wait until the other PR is reviewed in case we need to make some changes here?

@dyackzan dyackzan force-pushed the add-add-tool-in-world-srv branch 2 times, most recently from 2c7117f to a56de69 Compare October 31, 2024 16:40
* Add AddTool Srv
* Consolidate DetachTool/RemoveTool srvs
* Remove no longer needed fields in AttachTool srv
@dyackzan dyackzan force-pushed the add-add-tool-in-world-srv branch from a56de69 to 341f6ff Compare November 8, 2024 15:38
@dyackzan dyackzan merged commit c7d7baa into main Nov 14, 2024
2 checks passed
@dyackzan dyackzan deleted the add-add-tool-in-world-srv branch November 14, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaks behavior or site config APIs and requires migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants