Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update chinese translation #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yoshimo0417
Copy link

-fix the chinese gibberish problem in WeiDU.log
-fix few chinese strings

-fix the chinese gibberish problem in WeiDU.log
-fix few chinese strings
�������ඨ����~
�������ϣ�

װ��������
Copy link
Collaborator

@Roberciiik Roberciiik Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you applied EE-specific format of items, you should use Setup-Assassinations-EE,tra file for this. See Polish language file for reference.

@@ -59,7 +59,7 @@ LANGUAGE ~German (Translated by Toran)~ ~German~ ~Assassinations/German/Setup-As
LANGUAGE ~Italian (Translated by ilot)~ ~Italian~ ~Assassinations/Italian/Setup-Assassinations.tra~
LANGUAGE ~Polish (Translated by Cuttooth)~ ~Polish~ ~Assassinations/Polish/Setup-Assassinations.tra~
LANGUAGE ~French (Translated by Le Marquis)~ ~French~ ~Assassinations/French/Setup-Assassinations.tra~
LANGUAGE ~Chinese (Translated by Merzbau)~ ~Schinese~ ~Assassinations/Schinese/Setup-Assassinations.tra~
LANGUAGE ~Chinese (Translated by Merzbau)~ ~Schinese~ ~Assassinations/Schinese/Setup-%WEIDU_OS%.tra~
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More safe option would be to write it as:

LANGUAGE ~Chinese (Translated by Merzbau)~ ~Schinese~ 
    ~Assassinations/Schinese/Setup-Assassinations.tra~
    ~Assassinations/Schinese/Setup-%WEIDU_OS%.tra~

To load setup file first and then override it with OS-dependent translations.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reply. I have fix that two problems you mentioned above. Please check.

-Restore the format of item in Setup-Assassinations.tra to origin game, using Setup-Assassinations-EE.tra to applying EE-specific format
-fixed Assassinations.tp2
Copy link
Collaborator

@Roberciiik Roberciiik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing comments. Looks good now. (I can't appove it as don't have privileges)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants