fix(experiments): Prevent crash when sharedMetrics isn't loaded #28663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a defensive null check in the experiments feature to prevent runtime crashes when shared metrics data hasn't loaded yet.
- Added null check for
sharedMetricsinfrontend/src/scenes/experiments/experimentLogic.tsxto prevent "cannot filter null" error - Ensures graceful handling when shared metrics data is still loading or unavailable
- Maintains compatibility with existing shared metrics functionality while improving error handling
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
andehen
approved these changes
Feb 13, 2025
danielbachhuber
merged commit 7a01626
into
init-new-experiment-query-runner
98 of 99 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges into #28347
Changes
Prevents 'cannot filter null' error when sharedMetrics isn't yet loaded.
How did you test this code?
Manual review.