-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config forbid same server-port and admin-server-port #3559
Merged
steve-chavez
merged 8 commits into
PostgREST:main
from
develop7:fix-3508-neq_app_admin_ports
Jul 3, 2024
Merged
config forbid same server-port and admin-server-port #3559
steve-chavez
merged 8 commits into
PostgREST:main
from
develop7:fix-3508-neq_app_admin_ports
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
develop7
force-pushed
the
fix-3508-neq_app_admin_ports
branch
from
May 29, 2024 15:47
7d33ceb
to
1526130
Compare
develop7
force-pushed
the
fix-3508-neq_app_admin_ports
branch
from
June 19, 2024 09:05
84f07c8
to
c5c86be
Compare
Forbids server-port and admin-server-port from being equal altogether, despite they might not conflict at all in case admin and app are bound to different addresses. Implemented as per the discussion at PostgREST#3508 (comment)
develop7
force-pushed
the
fix-3508-neq_app_admin_ports
branch
from
June 25, 2024 17:28
ca646db
to
59a8550
Compare
laurenceisla
reviewed
Jul 2, 2024
steve-chavez
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbids
server-port
andadmin-server-port
from being equal altogether, despite they might not conflict at all in case admin and app are bound to different addresses. Implemented as per the discussion at#3508 (comment)
Fixes #3508