Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config forbid same server-port and admin-server-port #3559

Merged
merged 8 commits into from
Jul 3, 2024

Conversation

develop7
Copy link
Collaborator

Forbids server-port and admin-server-port from being equal altogether, despite they might not conflict at all in case admin and app are bound to different addresses. Implemented as per the discussion at
#3508 (comment)

Fixes #3508

@develop7 develop7 force-pushed the fix-3508-neq_app_admin_ports branch from 7d33ceb to 1526130 Compare May 29, 2024 15:47
@develop7 develop7 force-pushed the fix-3508-neq_app_admin_ports branch from 84f07c8 to c5c86be Compare June 19, 2024 09:05
@develop7 develop7 marked this pull request as ready for review June 19, 2024 09:05
CHANGELOG.md Outdated Show resolved Hide resolved
Forbids server-port and admin-server-port from being equal altogether,
despite they might not conflict at all in case admin and app are bound
to different addresses. Implemented as per the discussion at
PostgREST#3508 (comment)
@develop7 develop7 force-pushed the fix-3508-neq_app_admin_ports branch from ca646db to 59a8550 Compare June 25, 2024 17:28
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@steve-chavez steve-chavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯

@steve-chavez steve-chavez merged commit 06cbc4b into PostgREST:main Jul 3, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Server port and admin server port can end up with the same value
3 participants