-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep AppVM boot modes and template AppVM default boot mode in sync #666
Conversation
@qubes.events.handler( | ||
"property-reset:appvm_default_bootmode", | ||
) | ||
def on_property_bootmode_appvm_reset(self, event, name, oldvalue=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pylint says too long name, but IMO it fits, just add ignore comment
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031004-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests32 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 8 fixed
Unstable testsPerformance TestsPerformance degradation:28 performance degradations
Remaining performance tests:44 tests
|
f628cb7
to
d9831e7
Compare
Fixed pylint gripe. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
==========================================
+ Coverage 70.07% 70.16% +0.08%
==========================================
Files 59 59
Lines 12683 12726 +43
==========================================
+ Hits 8888 8929 +41
- Misses 3795 3797 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qube Manager was showing the wrong boot mode kernel options for AppVMs if you changed a template's AppVM default boot mode. Issue had a similar root cause to #653 (comment). This PR fixes it.