Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reproduce bug in qrexec tests #661

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Reproduce bug in qrexec tests #661

wants to merge 1 commit into from

Conversation

DemiMarie
Copy link
Contributor

The qrexec tests are broken and fail intermittently. This patch makes the bug obvious: by adding a sleep, it causes the test to fail right away, reliably.

@DemiMarie
Reproduce bug in qrexec tests
87f187d 
The qrexec tests are broken and fail intermittently.  This patch makes
the bug obvious: by adding a sleep, it causes the test to fail right
away, reliably.
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.72%. Comparing base (5de215d) to head (87f187d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   69.79%   69.72%   -0.07%     
==========================================
  Files          58       58              
  Lines       12546    12546              
==========================================
- Hits         8756     8748       -8     
- Misses       3790     3798       +8
Flag Coverage Δ
unittests 69.72% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Feb 23, 2025
Merged
Merged
Merged
Open
Merged
Merged
Open
Merged
Merged
@qubesos-bot
Copy link

qubesos-bot commented Feb 23, 2025 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031004-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update

Failed tests

32 failures

  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for anon-whonix failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for whonix-gateway-17 failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for whonix-workstation-17 failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...

  • system_tests_splitgpg

  • system_tests_qrexec

  • system_tests_kde_gui_interactive

    • simple_gui_apps: unnamed test (unknown)

    • simple_gui_apps: Failed (test died)
      # Test died: no candidate needle with tag(s) 'vm-settings-app-evinc...

    • simple_gui_apps: unnamed test (unknown)

  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for anon-whonix failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for whonix-gateway-17 failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for whonix-workstation-17 failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_basic_vm_qrexec_gui_btrfs

    • TC_03_QvmRevertTemplateChanges: test_000_revert_linux (error)
      subprocess.CalledProcessError: Command '['sha1sum', '/var/lib/qubes...

  • system_tests_suspend@hw1

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...

  • system_tests_extra

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/129058#dependencies

8 fixed

  • system_tests_whonix

  • system_tests_qrexec

  • system_tests_kde_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'clipboard-paste-notif...

  • system_tests_audio

  • system_tests_whonix@hw7

Unstable tests

Performance Tests

Performance degradation:

28 performance degradations
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 244937.00 :small_red_triangle_up: ( previous job: 486352.00, degradation: 50.36%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 208754.00 :small_red_triangle_up: ( previous job: 276742.00, degradation: 75.43%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 59601.00 :small_red_triangle_up: ( previous job: 423495.00, degradation: 14.07%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 88041.00 :small_red_triangle_up: ( previous job: 185030.00, degradation: 47.58%)
  • fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 3051.00 :small_red_triangle_up: ( previous job: 3785.00, degradation: 80.61%)
  • fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 79056.00 :small_red_triangle_up: ( previous job: 87999.00, degradation: 89.84%)
  • fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 3156.00 :small_red_triangle_up: ( previous job: 3885.00, degradation: 81.24%)
  • fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1022.00 :small_red_triangle_up: ( previous job: 1613.00, degradation: 63.36%)
  • fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 341222.00 :small_red_triangle_up: ( previous job: 392725.00, degradation: 86.89%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2308.00 :small_red_triangle_up: ( previous job: 3959.00, degradation: 58.30%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1844.00 :small_red_triangle_up: ( previous job: 2693.00, degradation: 68.47%)
  • debian-12-xfce_exec: 8.37 :small_red_triangle_up: ( previous job: 7.15, degradation: 117.01%)
  • debian-12-xfce_exec-data-simplex: 72.77 :small_red_triangle_up: ( previous job: 48.93, degradation: 148.73%)
  • debian-12-xfce_exec-data-duplex: 67.40 :small_red_triangle_up: ( previous job: 50.76, degradation: 132.77%)
  • debian-12-xfce_exec-data-duplex-root: 85.22 :small_red_triangle_up: ( previous job: 64.91, degradation: 131.30%)
  • debian-12-xfce_socket-data-duplex: 162.33 :small_red_triangle_up: ( previous job: 81.49, degradation: 199.21%)
  • fedora-41-xfce_exec-data-simplex: 66.12 :small_red_triangle_up: ( previous job: 49.65, degradation: 133.18%)
  • fedora-41-xfce_exec-data-duplex: 66.77 :small_red_triangle_up: ( previous job: 49.08, degradation: 136.04%)
  • fedora-41-xfce_exec-data-duplex-root: 92.61 :small_red_triangle_up: ( previous job: 81.65, degradation: 113.42%)
  • fedora-41-xfce_socket-data-duplex: 153.65 :small_red_triangle_up: ( previous job: 78.62, degradation: 195.42%)
  • whonix-gateway-17_exec-data-simplex: 59.47 :small_red_triangle_up: ( previous job: 48.76, degradation: 121.95%)
  • whonix-gateway-17_exec-data-duplex: 78.68 :small_red_triangle_up: ( previous job: 48.55, degradation: 162.04%)
  • whonix-gateway-17_exec-data-duplex-root: 93.82 :small_red_triangle_up: ( previous job: 70.13, degradation: 133.79%)
  • whonix-gateway-17_socket-data-duplex: 163.34 :small_red_triangle_up: ( previous job: 82.74, degradation: 197.41%)
  • whonix-workstation-17_exec-data-simplex: 64.19 :small_red_triangle_up: ( previous job: 47.01, degradation: 136.52%)
  • whonix-workstation-17_exec-data-duplex: 72.97 :small_red_triangle_up: ( previous job: 49.48, degradation: 147.48%)
  • whonix-workstation-17_exec-data-duplex-root: 99.46 :small_red_triangle_up: ( previous job: 79.93, degradation: 124.43%)
  • whonix-workstation-17_socket-data-duplex: 162.49 :small_red_triangle_up: ( previous job: 81.71, degradation: 198.86%)

Remaining performance tests:

44 tests
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 100592.00 :small_red_triangle_up: ( previous job: 100699.00, degradation: 99.89%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 7527.00 :green_circle: ( previous job: 3277.00, improvement: 229.69%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 12093.00 :green_circle: ( previous job: 10163.00, improvement: 118.99%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 4856.00 :green_circle: ( previous job: 282.00, improvement: 1721.99%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 495780.00 :green_circle: ( previous job: 475329.00, improvement: 104.30%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 273066.00 :green_circle: ( previous job: 95209.00, improvement: 286.81%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 438001.00 :green_circle: ( previous job: 433474.00, improvement: 101.04%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 184287.00 :green_circle: ( previous job: 164133.00, improvement: 112.28%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 106824.00 :green_circle: ( previous job: 99808.00, improvement: 107.03%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 9098.00 :green_circle: ( previous job: 8767.00, improvement: 103.78%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7600.00 :green_circle: ( previous job: 7053.00, improvement: 107.76%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3803.00 :small_red_triangle_up: ( previous job: 3868.00, degradation: 98.32%)
  • fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 387930.00 :small_red_triangle_up: ( previous job: 396586.00, degradation: 97.82%)
  • fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 282940.00 :green_circle: ( previous job: 99783.00, improvement: 283.56%)
  • fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 320469.00 :small_red_triangle_up: ( previous job: 343795.00, degradation: 93.22%)
  • fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 54193.00 :green_circle: ( previous job: 44770.00, improvement: 121.05%)
  • fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 92146.00 :green_circle: ( previous job: 86742.00, improvement: 106.23%)
  • fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8728.00 :green_circle: ( previous job: 8623.00, improvement: 101.22%)
  • fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1545.00 :green_circle: ( previous job: 1126.00, improvement: 137.21%)
  • fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 384093.00 :small_red_triangle_up: ( previous job: 401907.00, degradation: 95.57%)
  • fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 147360.00 :green_circle: ( previous job: 116848.00, improvement: 126.11%)
  • fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 330781.00 :small_red_triangle_up: ( previous job: 357875.00, degradation: 92.43%)
  • fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 50945.00 :green_circle: ( previous job: 41375.00, improvement: 123.13%)
  • fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 7980.00 :small_red_triangle_up: ( previous job: 8744.00, degradation: 91.26%)
  • fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 189167.00 :green_circle: ( previous job: 139933.00, improvement: 135.18%)
  • fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 307410.00 :green_circle: ( previous job: 294875.00, improvement: 104.25%)
  • fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 126235.00 :green_circle: ( previous job: 78093.00, improvement: 161.65%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 81383.00 :green_circle: ( previous job: 71108.00, improvement: 114.45%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8338.00 :small_red_triangle_up: ( previous job: 8408.00, degradation: 99.17%)
  • debian-12-xfce_exec-root: 29.21 :small_red_triangle_up: ( previous job: 27.97, degradation: 104.45%)
  • debian-12-xfce_socket: 9.11 :small_red_triangle_up: ( previous job: 8.33, degradation: 109.38%)
  • debian-12-xfce_socket-root: 9.02 :small_red_triangle_up: ( previous job: 8.20, degradation: 109.95%)
  • fedora-41-xfce_exec: 9.39 :small_red_triangle_up: ( previous job: 9.13, degradation: 102.76%)
  • fedora-41-xfce_exec-root: 61.54 :small_red_triangle_up: ( previous job: 61.17, degradation: 100.61%)
  • fedora-41-xfce_socket: 8.10 🟢 ( previous job: 8.66, improvement: 93.55%)
  • fedora-41-xfce_socket-root: 8.94 :small_red_triangle_up: ( previous job: 8.61, degradation: 103.89%)
  • whonix-gateway-17_exec: 6.56 🟢 ( previous job: 7.87, improvement: 83.44%)
  • whonix-gateway-17_exec-root: 40.25 :small_red_triangle_up: ( previous job: 38.36, degradation: 104.92%)
  • whonix-gateway-17_socket: 7.39 🟢 ( previous job: 7.54, improvement: 97.92%)
  • whonix-gateway-17_socket-root: 8.70 :small_red_triangle_up: ( previous job: 8.27, degradation: 105.15%)
  • whonix-workstation-17_exec: 8.66 :small_red_triangle_up: ( previous job: 8.23, degradation: 105.24%)
  • whonix-workstation-17_exec-root: 55.52 :small_red_triangle_up: ( previous job: 52.56, degradation: 105.62%)
  • whonix-workstation-17_socket: 8.74 :small_red_triangle_up: ( previous job: 8.21, degradation: 106.50%)
  • whonix-workstation-17_socket-root: 8.57 :small_red_triangle_up: ( previous job: 8.20, degradation: 104.56%)

This was referenced Feb 23, 2025
Merged
Merged
Merged
Merged
Merged
@marmarek
Copy link
Member

I don't see any failure with this PR (but not QubesOS/qubes-core-qrexec#186): https://openqa.qubes-os.org/tests/129865

This was referenced Feb 23, 2025
Merged
Merged
Open
Merged
Merged
Open
Merged
Merged
Merged
Merged
@qubesos-bot qubesos-bot mentioned this pull request Mar 3, 2025
Merged
This was referenced Mar 3, 2025
Draft
Merged
Merged
Merged
@qubesos-bot qubesos-bot mentioned this pull request Mar 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
openqa-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DemiMarie @qubesos-bot @marmarek