fix(qubes-download-dom0-updates): manually specify vars dir in args #555
Conversation
gianklug
force-pushed
the
fix/qubes-download-dom0-updates/add_vars_arg
branch
2 times, most recently
from
679ddab to
3f1b9ed
Compare
|
Commit signing should've been fixed, please re-run. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 3 3
Lines 469 469
=======================================
Hits 331 331
Misses 138 138 ☔ View full report in Codecov by Sentry. |
Looks like the bot for checking signatures doesn't support SSH signing... ignore this problem for now. |
|
openQA said now installing packages for dom0 fails with: The "r41" in the URL is wrong, should be "r4.3". Looks like it took fedora version from updatevm, instead of qubes-release version from dom0's rpmdb. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025022714-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests21 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 15 fixed
Unstable testsPerformance TestsPerformance degradation:15 performance degradations
Remaining performance tests:25 tests
|
|
Yes, it's this PR. A test run without it works okay. |
|
Oh, well. Guess I'll have to do some debugging as to why this happens. Does the OpenQA test use any non-standard dnf variables or overwrites some standard ones? That would probably explain the errors. |
This is the thing that failed specifically. So, it's |
|
You can find full salt output at https://openqa.qubes-os.org/tests/130400/file/update_guivm-qubesctl-sys-gui.log |
This fixes custom vars for DNF on updatevms running Fedora 41.
Even though the custom variables are copied over here,
dnfonly replaces them with the added args in this patch on Fedora versions > 40.