Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: verification grid result downloads #2169

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: verification grid result downloads #2169

merged 1 commit into from
Nov 14, 2024

Conversation

hudson-newey
Copy link
Member

@hudson-newey hudson-newey commented Nov 12, 2024 •
edited
Loading

fix: verification grid result downloads

Changes

  • Bumps web component version to fix the download format of paginated result downloads
  • Removes tag model stringification hack previously implemented because the web components didn't support tag arrays

Issues

Fixes: #2168

Final Checklist

  • Assign reviewers if you have permission
  • Assign labels if you have permission
  • Link issues related to PR
  • Ensure project linter is not producing any warnings (npm run lint)
  • Ensure build is passing on all browsers (npm run test:all)
  • Ensure CI build is passing
  • Ensure docker container is passing (docs)

@hudson-newey hudson-newey added the bug Something isn't working label Nov 12, 2024
@hudson-newey hudson-newey self-assigned this Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Size Change: +629 B (+0.02%)

Total Size: 3.59 MB

Filename Size Change
dist/workbench-client/browser/@ecoacoustics/web-components/_commonjsHelpers-BVfed4GL.js 0 B -432 B (removed) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/classification-syqJf8YO.js 0 B -125 B (removed) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/colors-DMCqRncD.js 0 B -328 B (removed) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/components.js 116 kB +28 B (+0.02%)
dist/workbench-client/browser/@ecoacoustics/web-components/components/classification.js 1.77 kB -4 B (-0.23%)
dist/workbench-client/browser/@ecoacoustics/web-components/components/data-source.js 63.3 kB +18 B (+0.03%)
dist/workbench-client/browser/@ecoacoustics/web-components/components/decision.js 246 B -1 kB (-80.34%) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/components/indicator.js 1.12 kB +3 B (+0.27%)
dist/workbench-client/browser/@ecoacoustics/web-components/components/media-controls.js 38.2 kB +6 B (+0.02%)
dist/workbench-client/browser/@ecoacoustics/web-components/components/spectrogram.js 226 B -167 kB (-99.86%) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/components/verification-grid-tile.js 408 B -3.14 kB (-88.5%) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/components/verification-grid.js 396 B +9 B (+2.33%)
dist/workbench-client/browser/@ecoacoustics/web-components/components/verification.js 1.29 kB -11 B (-0.84%)
dist/workbench-client/browser/@ecoacoustics/web-components/custom-elements.json 9.74 kB +148 B (+1.54%)
dist/workbench-client/browser/@ecoacoustics/web-components/decision-Btskh9bB.js 0 B -202 B (removed) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/decisionColors-DNuXUVq4.js 0 B -3.84 kB (removed) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/directive-helpers-DAca9yBy.js 0 B -638 B (removed) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/keyboard-MZyub3T-.js 0 B -117 B (removed) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/userAgent-CdrtNGdV.js 0 B -1.04 kB (removed) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/utilities-C38J31_r.js 0 B -432 B (removed) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/verification-grid-DnTXiJ40.js 0 B -12.1 kB (removed) 🏆
dist/workbench-client/browser/@ecoacoustics/web-components/watch-BnoWuiCc.js 0 B -1.02 kB (removed) 🏆
dist/workbench-client/browser/index.html 4.79 kB -2 B (-0.04%)
dist/workbench-client/browser/main-SHI5ZZQN.js 0 B -1.13 MB (removed) 🏆
dist/workbench-client/server/main.js 1.94 MB -19 B (0%)
dist/workbench-client/browser/@ecoacoustics/web-components/classification-CIken_-O.js 128 B +128 B (new file) 🆕
dist/workbench-client/browser/@ecoacoustics/web-components/decision-BcFlFKnV.js 1.49 kB +1.49 kB (new file) 🆕
dist/workbench-client/browser/@ecoacoustics/web-components/decision-BvBt2W07.js 4.03 kB +4.03 kB (new file) 🆕
dist/workbench-client/browser/@ecoacoustics/web-components/keyboard-c8_TPhbG.js 117 B +117 B (new file) 🆕
dist/workbench-client/browser/@ecoacoustics/web-components/spectrogram-CYEtaRIV.js 168 kB +168 kB (new file) 🆕
dist/workbench-client/browser/@ecoacoustics/web-components/verification-grid-CT6ze_9z.js 12.4 kB +12.4 kB (new file) 🆕
dist/workbench-client/browser/@ecoacoustics/web-components/verification-grid-tile-CvcYjTk-.js 4.49 kB +4.49 kB (new file) 🆕
dist/workbench-client/browser/@ecoacoustics/web-components/watch-D97VecW3.js 1.42 kB +1.42 kB (new file) 🆕
dist/workbench-client/browser/main-NJJYAUE5.js 1.13 MB +1.13 MB (new file) 🆕
ℹ️ View Unchanged
Filename Size
dist/workbench-client/browser/@ecoacoustics/web-components/abstractComponent-gI12hGSz.js 6.49 kB
dist/workbench-client/browser/@ecoacoustics/web-components/assets/buffer-builder-processor-BhnxGUx8.js 1.16 kB
dist/workbench-client/browser/@ecoacoustics/web-components/assets/high-accuracy-time-processor-BevUJNwo.js 354 B
dist/workbench-client/browser/@ecoacoustics/web-components/attributes-DayhhJl-.js 313 B
dist/workbench-client/browser/@ecoacoustics/web-components/class-map-BJ2wQJjp.js 675 B
dist/workbench-client/browser/@ecoacoustics/web-components/components/axes.js 3.19 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/help-dialog.js 2.61 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/helpers/constants/contextTokens.js 209 B
dist/workbench-client/browser/@ecoacoustics/web-components/components/info-card.js 1.59 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/logger.js 418 B
dist/workbench-client/browser/@ecoacoustics/web-components/components/progress-bar.js 1.13 kB
dist/workbench-client/browser/@ecoacoustics/web-components/components/verification-grid-settings.js 1.48 kB
dist/workbench-client/browser/@ecoacoustics/web-components/consume-D2RSb1qY.js 614 B
dist/workbench-client/browser/@ecoacoustics/web-components/context-request-event-Bc4uem__.js 239 B
dist/workbench-client/browser/@ecoacoustics/web-components/decorators-zsXcIcN9.js 516 B
dist/workbench-client/browser/@ecoacoustics/web-components/directive-B76A7YXI.js 343 B
dist/workbench-client/browser/@ecoacoustics/web-components/if-defined-YSzpD1Zv.js 178 B
dist/workbench-client/browser/@ecoacoustics/web-components/lit-element-CNpxFSzF.js 6.77 kB
dist/workbench-client/browser/@ecoacoustics/web-components/map-D8heArFD.js 184 B
dist/workbench-client/browser/@ecoacoustics/web-components/property-cctOu2Be.js 639 B
dist/workbench-client/browser/@ecoacoustics/web-components/provide-Ce8Vz0mw.js 1.18 kB
dist/workbench-client/browser/@ecoacoustics/web-components/query-sbFTBDPt.js 340 B
dist/workbench-client/browser/@ecoacoustics/web-components/signal-watcher-CbQ3umdl.js 377 B
dist/workbench-client/browser/@ecoacoustics/web-components/signals-core.module-BUxpRF5s.js 1.59 kB
dist/workbench-client/browser/@ecoacoustics/web-components/state-DJrhCpxL.js 203 B
dist/workbench-client/browser/@ecoacoustics/web-components/when-CDK1Tt5Y.js 168 B
dist/workbench-client/browser/assets/environment.json 555 B
dist/workbench-client/browser/assets/test-assets/index.html 21 B
dist/workbench-client/browser/manifest.json 147 B
dist/workbench-client/browser/polyfills-C5CKP5CH.js 12.4 kB
dist/workbench-client/browser/styles-ETV6J7SM.css 39.6 kB
dist/workbench-client/server/952.js 4.21 kB

compressed-size-action

@hudson-newey hudson-newey marked this pull request as ready for review November 12, 2024 06:25
@hudson-newey hudson-newey removed the request for review from atruskie November 12, 2024 06:37
@hudson-newey
bump web components version
c78bcbb 
This web components bump includes fixes for verification grid result
downloads by calling toJSON on subject models.

This commit also removes the hacky stringification of tag names in the
workbench client as the web components can now handle an array of tags

Fixes: #2168
@hudson-newey hudson-newey force-pushed the fix-verification-downloads branch from 8fc0a96 to c78bcbb Compare November 14, 2024 04:12
@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results

         4 files           4 suites   7m 4s ⏱️
16 052 tests 15 644 ✔️ 408 💤 0 ❌
16 200 runs  15 792 ✔️ 408 💤 0 ❌

Results for commit c78bcbb.

@atruskie atruskie merged commit e887fbc into master Nov 14, 2024
21 checks passed
@atruskie atruskie deleted the fix-verification-downloads branch November 14, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atruskie atruskie atruskie approved these changes

Assignees

@hudson-newey hudson-newey

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix verification grid downloads
2 participants
@hudson-newey @atruskie