-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add Profile management #444
Conversation
Holy fuck this is so cool :DDDDD Good thing I got distracted with working on some other FlightCore feature today cause otherwise we would have done the same work at once lmao xD |
It would be fine, two people working on the same thing would give you two unique perspectives on the implementation, allowing you to cherry pick the best of both worlds :) |
for the sake of not making this an absolute nightmare, I'll split this up into chunks and make new PRs for them. |
Passes the whole `GameInstall` object instead of individual path to functions related to PR installs. This is done in preparation for #444
This isn't the end of it, but all front facing functionality that would need to support Profiles is done. Things to get done in the future:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So happy to see the progress :D
Left a few small comments.
With that said, I think we should try to still further reduce the diff a bit. In particular, as a next step I would splice out the Rust code for profile fetching/validation into a separate PR.
Add some buttons to test it in DevView and then we can merge that early as well.
After that it might also make sense to have the profile selection field in DevView for a bit so that we can make a release where contributors can basically test it in production.
Once it's considered stable we would just move the controls to settings for actual "release" ^^
squashed all commits every single commit was tested to work (on Linux) individually and ran against clippy and the formatter. This should make a review more feasible to do. |
You're a saint. Will take a look tonight, thanks <3 |
little issue I have found: |
Didn't get to it, sorry :/ Given the nice commit structure, my plan is to just cherry-pick a the first few changes into separate PRs, so if you wanna get ahead of me feel free to just cherry-pick the first commit into a new PR and I will hopefully get to it tomorrow <3 |
This adds a button and corresponding logic to delete an existing profile Spliced out from #444 Co-authored-by: Jan <[email protected]>
This adds a button and corresponding logic to delete an existing profile Spliced out from #444 Co-authored-by: Jan <[email protected]>
Superseded by #761 |
meta PR to keep all the not yet PRable commits for profile management.
each and every one is going to be PR'd independenly and the profiles branch will get rebased after a merge.