-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow writable complex types in extensions #61
Allow writable complex types in extensions #61
Conversation
This looks interesting but a test fails. Hopefully an easy fix! Please ensure that I also have the same request as for #62 - it needs docs in |
@pond I'll be giving some more love to this work after this wed, thanks for reviewing! |
I agree… Reading through the docs gave me the sense that it deserves some reorganization, updates and to dig a bit further on some topics. This is in my backlog, but might be a bit down the list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good now - thanks for the docs additions.
My goal is to be able to add groups to users, the same way we can add users to groups. Since that's not allowed by the SCIM default User schema, I have an extension type like this:
But I'm currently not able to use this type like this in my project:
Without this patch, this is what I get:
Because
[{ value: "123" }]
never gets cast to the complex type.Ps.: this is the generated request in the above example: