[MFMA][FRONTEND] Add more options for forced mfma layout sizes #538
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR: - adds an `matrix_instr_nonkdim` options to force MFMA 64x4 and 4x64 layout: 464 corresponds 4(M)x64(N), 644 corresponds 64(M)x4(N) - adds tests for this option - fixes swizzling patter in some cases MFMA size heuristic now looks like this: 1. If kernel specific option is set, pick it 2. If the result tile shape is larger than 32x32, pick mfma32 3. If the tile shape is smaller than 32x32 but larger than 16x16, pick mfma16 4. if the tile shape is smaller than 4x64 or 64x4, pick mfma4x4 5. Otherwise, pick mfma4x64 or mfma64x4, depending on what tile fits into matrices
binarman
force-pushed
the
mfma464_option
branch
from
eeb0d4c
to
8e9ca66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
matrix_instr_nonkdimoptions to force MFMA 64x4 and 4x64 layout: 464 corresponds 4(M)x64(N), 644 corresponds 64(M)x4(N)MFMA size heuristic now looks like this: