Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFMA][FRONTEND] Add more options for forced mfma layout sizes #538

Open
wants to merge 2 commits into
base: triton-mlir
Choose a base branch
from
Open

[MFMA][FRONTEND] Add more options for forced mfma layout sizes #538

wants to merge 2 commits into from

Commits on Mar 19, 2024

  1. [MFMA][FRONTEND] Add more options for forced mfma layout sizes 

    This PR:
- adds an `matrix_instr_nonkdim` options to force MFMA 64x4 and 4x64 layout: 464 corresponds 4(M)x64(N), 644 corresponds 64(M)x4(N)
- adds tests for this option
- fixes swizzling patter in some cases

MFMA size heuristic now looks like this:

1. If kernel specific option is set, pick it
2. If the result tile shape is larger than 32x32, pick mfma32
3. If the tile shape is smaller than 32x32 but larger than 16x16, pick mfma16
4. if the tile shape is smaller than 4x64 or 64x4, pick mfma4x4
5. Otherwise, pick mfma4x64 or mfma64x4, depending on what tile fits into matrices
    @binarman
    binarman committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3298cde View commit details
    Browse the repository at this point in the history

  2. fix typo

    @alefimov-amd @binarman
    alefimov-amd authored and binarman committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8e9ca66 View commit details
    Browse the repository at this point in the history