Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ca2+ example run and add submit scripts for HPC cluster #6

Merged
merged 28 commits into from
Jan 3, 2024

Conversation

finsberg
Copy link
Collaborator

@finsberg finsberg commented Oct 30, 2023

  • Remove some unused imports
  • Added back some info used in mesh creation (in particular z_PSD which is needed later)
  • Edited integratedDomain
    • The line integrateDomain = d.MeshFunction("size_t", spine_mesh, 2, facet_markers_orig) didn't make sense when facet_markers_orig was also a MeshFunction
  • Remove print_assembly from config
  • Run formatter
  • Make it possible to set paths via environment variables which is useful when submitting jobs.

@finsberg finsberg force-pushed the finsberg/fix-ca2+-example branch from af55724 to 3ec39fb Compare October 30, 2023 20:32
@finsberg finsberg marked this pull request as ready for review October 30, 2023 20:36
@finsberg finsberg requested a review from emmetfrancis October 30, 2023 20:36
@finsberg finsberg changed the title Make example run Make ca2+ example run and add submit scripts for HPC cluster Oct 30, 2023
Copy link
Collaborator

@emmetfrancis emmetfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks and sorry again about the mess.

@emmetfrancis
Copy link
Collaborator

I went back into the file, should run as intended now. The initial condition with the "NMDAR" species needed to be set according to the facet markers from the mesh file. Right now, the method I used to do this is very inefficient, so please suggest any changes there if possible. The goal is to simply set NMDAR to 1.0 at all the locations where the facet marker is 11 (should be zero everywhere else)

@finsberg
Copy link
Collaborator Author

finsberg commented Nov 9, 2023

Added timers, see RangamaniLabUCSD/smart#151

" \"time_precision\": 8,\n",
" \"use_snes\": True,\n",
" \"print_assembly\": False,\n",
" # \"print_assembly\": False,\n",
" }\n",
")\n",
Copy link
Collaborator

@emmetfrancis emmetfrancis Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @finsberg , can add extra config setting for enforcing mass conservation. (could test with vs. without)

configCur.flags.update({"enforce_mass_conservation": True})

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added option in a38c65f

@finsberg finsberg merged commit ac6a1d6 into main Jan 3, 2024
emmetfrancis pushed a commit that referenced this pull request Jan 10, 2024
Make ca2+ example run and add submit scripts for HPC cluster
emmetfrancis pushed a commit that referenced this pull request Jan 10, 2024
Make ca2+ example run and add submit scripts for HPC cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants