adding an atime test case; new with optimization to allow avoid [ overhead #PR4488 #6290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated via commit e23e865 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 3 minutes and 18 seconds Time taken to run |
tdhock
reviewed
Jul 17, 2024
|
please revise #6288, and update this PR using the same advice in that other PR, before submitting more PRs |
Anirban166
reviewed
Jul 17, 2024
|
converting to draft so we can focus on #6288 first |
MichaelChirico
added
the
atime
Anirban166
reviewed
Sep 13, 2024
| DoSomething <- function(row) { | ||
| someCalculation <- row[["v1"]] + 1 | ||
| } | ||
| allIteration_dt <- as.data.table(allIterations) |
There was a problem hiding this comment.
what's the point of this line? it's not being used anywhere inside the evaluated expression, noh? (expr is only using allIterations)
| setup = { | ||
| allIterations <- data.frame(v1 = runif(N), v2 = runif(N)) | ||
| DoSomething <- function(row) { | ||
| someCalculation <- row[["v1"]] + 1 |
There was a problem hiding this comment.
Needs indentation within this scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was reported in #3735. The issue was reported that, selecting by row number from a data.table is much slower than from a data.frame.
The pull request that fixed the regression can be found #4488. However, I couldn’t find specific details about the changes made to fix the regression. It’s likely that the changes involved optimizing the way data.table handles row selection to make it more efficient.