Message fixes for the C code #6504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it's very hard to translate without pgettext() in a language where "there is no <x>" is translated as "<x> is absent"
This will avoid potential word order issues.
.Last.value is a variable in the global environment. .Last.updated belongs to the data.table package.
|
Generated via commit 384fe62 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 3 minutes and 22 seconds Time taken to run |
MichaelChirico
added
the
translation
Co-authored-by: Michael Chirico <[email protected]>
Anirban166
reviewed
Sep 17, 2024
8 tasks
Co-authored-by: rikivillalba <[email protected]>
Hopefully the compiler will be smart enough to inline it back. Co-authored-by: Michael Chirico <[email protected]>
Forgot to take #6504 (comment) into account.
|
Don't regenerate the .pot file in this PR, save it for a follow-up |
| } | ||
| MSBsize = shrinkMSB(MSBsize, msbCounts, order, verbose); |
There was a problem hiding this comment.
I might have assumed this helper would be by-reference on MSBsize; OTOH, it's a single size_t and this is only done once in fsort(). The impact should not be noticed.
MichaelChirico
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves some of the obvious issues in #6503. I can expand on the more tough or less obvious ones when we decide which ones to fix and how.
po/data.table.pot