Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message fixes for the C code #6504

Merged
merged 20 commits into from
Sep 20, 2024
Merged

Message fixes for the C code #6504

merged 20 commits into from
Sep 20, 2024
+36 −21

Commits on Sep 17, 2024

  1. Expand the fragmented sentence 

    Otherwise it's very hard to translate without pgettext() in a language
where "there is no <x>" is translated as "<x> is absent"
    @aitap
    aitap committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3618b91 View commit details
    Browse the repository at this point in the history

  2. Combine the fragmented sentence 

    This will avoid potential word order issues.
    @aitap
    aitap committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6448d49 View commit details
    Browse the repository at this point in the history

  3. Correct internal error message 

    .Last.value is a variable in the global environment. .Last.updated belongs to the data.table package.
    @aitap
    aitap committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2e2dcd2 View commit details
    Browse the repository at this point in the history

  4. data.table-help -> data.table issue tracker

    @aitap
    aitap committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    87d53c5 View commit details
    Browse the repository at this point in the history

  5. Avoid templating on the known value of a variable

    @aitap
    aitap committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    dc56552 View commit details
    Browse the repository at this point in the history

  6. When '9'+1 != ':', say it's ASCII-incompatible

    @aitap
    aitap committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f38c9b4 View commit details
    Browse the repository at this point in the history

  7. Don't check for length(.) < 0

    @aitap
    aitap committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    bf90995 View commit details
    Browse the repository at this point in the history

  8. Use R capitalization for logical constants

    @MichaelChirico
    MichaelChirico authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6b36bdc View commit details
    Browse the repository at this point in the history

  9. newline->error for codecov

    @MichaelChirico
    MichaelChirico authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    36a3423 View commit details
    Browse the repository at this point in the history

  10. Use internal_error() instead of manual error handling 

    Co-authored-by: Michael Chirico <[email protected]>
    @aitap @MichaelChirico
    aitap and MichaelChirico authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3b376da View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. internal_error needs __func__

    @MichaelChirico
    MichaelChirico authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6a8030a View commit details
    Browse the repository at this point in the history

  2. Branch a previously templated translation

    @aitap
    aitap committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    bd5f323 View commit details
    Browse the repository at this point in the history

  3. Combine a fragmented sentence

    @rikivillalba @aitap
    rikivillalba authored and aitap committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9fe6ad0 View commit details
    Browse the repository at this point in the history

  4. Recombine "gather took %.3fs\n" 

    Co-authored-by: rikivillalba <[email protected]>
    @aitap @rikivillalba
    aitap and rikivillalba committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    95fbbed View commit details
    Browse the repository at this point in the history

  5. Split off the shrinkMSB helper 

    Hopefully the compiler will be smart enough to inline it back.

Co-authored-by: Michael Chirico <[email protected]>
    @aitap @MichaelChirico
    aitap and MichaelChirico committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    014a3ae View commit details
    Browse the repository at this point in the history

  6. Branch a fragmented verbose sentence in fread

    @aitap
    aitap committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    655495b View commit details
    Browse the repository at this point in the history

  7. Don't say we reduced MSBsize if it didn't change 

    Forgot to take #6504 (comment) into account.
    @aitap
    aitap committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    bebe9b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. declaration style for pointer spacing

    @MichaelChirico
    MichaelChirico authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7521491 View commit details
    Browse the repository at this point in the history

  2. line bump for codecov + readability

    @MichaelChirico
    MichaelChirico authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    384fe62 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into message-fixes

    @MichaelChirico
    MichaelChirico authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a80cf2d View commit details
    Browse the repository at this point in the history