Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update best practices #1010

Closed
wants to merge 1 commit into from
Closed

Conversation

riotschoolacc
Copy link

Changes

Use best practices.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@riotschoolacc riotschoolacc requested a review from a team as a code owner February 3, 2025 17:23
@github-actions github-actions bot added the engine guides Changes the Engine guides label Feb 3, 2025
@aetter aetter closed this Feb 3, 2025
@riotschoolacc
Copy link
Author

WHY WAS IT CLOSED

@aetter
Copy link
Contributor

aetter commented Feb 3, 2025

Hi @riotschoolacc, thanks for the PR, but this is just another way of accomplishing the same thing rather than an improvement. We use concatenation throughout the documentation, so choosing not to use it here is somewhat arbitrary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine guides Changes the Engine guides
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants