Remove Tolerance from OverlayParams in WorldRoot #1017
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
engine reference
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Only the following fields are editable: summary, description, deprecation_message. Other fields are automatically overwritten if edited. Please undo changes to the following fields:
methods.9.parameters.2.defaultmethods.10.parameters.2.defaultmethods.11.parameters.1.default
⛔️ This change is a requirement. Please fix it before merging.
There was a problem hiding this comment.
Right... Automatically generated yet it's incorrect...
There was a problem hiding this comment.
Hi @ari-party , we're looking into this and why it's not synced with the actual default. Thanks!
There was a problem hiding this comment.
@IgnisRBX Different thing that's semi related, where can one best report wrong luau types?
(Should be Player?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove Tolerance from OverlayParams in WorldRoot
Checks
By submitting your pull request for review, you agree to the following: