Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tolerance from OverlayParams in WorldRoot #1017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Remove Tolerance from OverlayParams in WorldRoot #1017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions content/en-us/reference/engine/classes/WorldRoot.yaml
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the following fields are editable: summary, description, deprecation_message. Other fields are automatically overwritten if edited. Please undo changes to the following fields:

  • methods.9.parameters.2.default
  • methods.10.parameters.2.default
  • methods.11.parameters.1.default

⛔️ This change is a requirement. Please fix it before merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... Automatically generated yet it's incorrect...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ari-party , we're looking into this and why it's not synced with the actual default. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgnisRBX Different thing that's semi related, where can one best report wrong luau types?
1738995930_gHsEO3x6x9
(Should be Player?)

Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ methods:
The size of the given box volume to be queried.
- name: overlapParams
type: OverlapParams
default: OverlapParams{MaxParts=0, Tolerance=0, BruteForceAllSlow=false, RespectCanCollide=false, CollisionGroup=Default, FilterDescendantsInstances={}}
default: OverlapParams{MaxParts=0, BruteForceAllSlow=false, RespectCanCollide=false, CollisionGroup=Default, FilterDescendantsInstances={}}
summary: |
Contains reusable portions of the spatial query parameters.
returns:
Expand Down Expand Up @@ -572,7 +572,7 @@ methods:
The radius of the given sphere volume to be queried.
- name: overlapParams
type: OverlapParams
default: OverlapParams{MaxParts=0, Tolerance=0, BruteForceAllSlow=false, RespectCanCollide=false, CollisionGroup=Default, FilterDescendantsInstances={}}
default: OverlapParams{MaxParts=0, BruteForceAllSlow=false, RespectCanCollide=false, CollisionGroup=Default, FilterDescendantsInstances={}}
summary: |
Contains reusable portions of the spatial query parameters.
returns:
Expand Down Expand Up @@ -621,7 +621,7 @@ methods:
The part whose volume is to be checked against other parts.
- name: overlapParams
type: OverlapParams
default: OverlapParams{MaxParts=0, Tolerance=0, BruteForceAllSlow=false, RespectCanCollide=false, CollisionGroup=Default, FilterDescendantsInstances={}}
default: OverlapParams{MaxParts=0, BruteForceAllSlow=false, RespectCanCollide=false, CollisionGroup=Default, FilterDescendantsInstances={}}
summary: |
Contains reusable portions of the spatial query parameters.
returns:
Expand Down
Loading