Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EditableMesh.yaml and AssetService.yaml #1018

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

sammygrey
Copy link
Contributor

@sammygrey sammygrey commented Feb 6, 2025

Changes

Changed one reference of "content" in EditableMesh.yaml to link to the Content datatype. Also added summaries for content parameters in AssetService.yaml to better explain what they are.

Credit to @MrChickenRocket for making the bug report here asking for clarification on Content.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@sammygrey sammygrey requested a review from a team as a code owner February 6, 2025 21:53
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Feb 6, 2025
@sammygrey
Copy link
Contributor Author

sammygrey commented Feb 6, 2025

There also needs to be edits made to the Code Sample for EditableMesh:RaycastLocal()to not use editableMesh:CreateMeshPartAsync() which is deprecated.

I'm working on a fix for this, but the recent changes to the EditableMesh datatype are making this a pain to debug.

Looks like theres an issue with the return type for AssetService:CreateEditableMeshAsync(), so I'll wait till my bug report is addressed for providing an example fix for this.

ConorGriffin37
ConorGriffin37 previously approved these changes Feb 7, 2025
@ConorGriffin37
Copy link
Member

ConorGriffin37 commented Feb 7, 2025

Thanks for the PR.

For the RaycastLocal code sample, we should just be able to change it to use AssetService:CreateMeshPartAsync(Content.fromObject(editableMesh))

I will follow up on the above bug report because I'm not sure if there is an issue there.

@IgnisRBX
Copy link
Contributor

IgnisRBX commented Feb 7, 2025

FYI @sammygrey , I just processed a separate update for the code sample you speak of to fix the issue. That should be synched live soon, so we can close the loop on this. :)

@IgnisRBX IgnisRBX merged commit 741b144 into Roblox:main Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine reference Changes the Engine API Reference documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants