-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EditableMesh.yaml and AssetService.yaml #1018
Conversation
Added summaries for [Content](https://create.roblox.com/docs/reference/engine/datatypes/Content) variables
added one extra use of [https://create.roblox.com/docs/reference/engine/datatypes/Content](Content) instead of just "content".
There also needs to be edits made to the Code Sample for EditableMesh:RaycastLocal()to not use editableMesh:CreateMeshPartAsync() which is deprecated. I'm working on a fix for this, but the recent changes to the EditableMesh datatype are making this a pain to debug. Looks like theres an issue with the return type for AssetService:CreateEditableMeshAsync(), so I'll wait till my bug report is addressed for providing an example fix for this. |
Thanks for the PR. For the RaycastLocal code sample, we should just be able to change it to use I will follow up on the above bug report because I'm not sure if there is an issue there. |
FYI @sammygrey , I just processed a separate update for the code sample you speak of to fix the issue. That should be synched live soon, so we can close the loop on this. :) |
Changes
Changed one reference of "content" in EditableMesh.yaml to link to the Content datatype. Also added summaries for content parameters in AssetService.yaml to better explain what they are.
Credit to @MrChickenRocket for making the bug report here asking for clarification on Content.
Checks
By submitting your pull request for review, you agree to the following: