[cmake] Turn off -Werror=extra -Werror=pedantic #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In no universe should Werror be enabled in end-user builds (rather than just developers local builds and CI checks), and certainly not for warning categories that Drake's own CI doesn't even enable. We don't want *this* repository to be a warning-catcher for Drake code. The easy fix for now is to just turn off the overly broad warning categories. This does not fix the bug that Werror=all is enabled for builds triggered by downstream users.
jwnimmer-tri
commented
Jul 9, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)
|
\CC @EricCousineau-TRI @IanTheEngineer FYI |
|
Thanks! CI errors appear to be unrelated to this PR: Will merge this PR and file issue about the segfault. |
|
Yeah. CI has been broken for weeks (months?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In no universe should Werror be enabled in end-user builds (rather than just developers local builds and CI checks), and certainly not for warning categories that Drake's own CI doesn't even enable. We don't want this repository to be a warning-catcher for Drake code.
The easy fix for now is to just turn off the overly broad warning categories. This does not fix the bug that Werror=all is enabled for builds triggered by downstream users.
This change is